Calls to println/eprintln

[ettom]

It would be nice if the library didn't just print stuff to stdout/stderr indiscriminately. AFAIK the idiomatic solution would be to use the log or tracing crate.

[njaard]

I agree! There are only a few cases of eprintln in the code. Many of them can be removed harmlessly.

The "disregarding database" error should be part of the user interface.

The biggest question is what to do about warning: invalid segment version. Is that a corrupt or malformed file a valid use for a panic?

[ettom]

I think that the library itself should never call (e)println and ideally it wouldn't panic either. In both cases, doing otherwise is taking control away from the application developer. What about propagating the disregarding database or invalid segment version and similar errors as Errs, with a custom Error type? For this, the thiserror create could help. You could have different variants with some of them being marked as recoverable and others as fatal, where appropriate.