Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify schema of the submission object #36

Open
tschaffter opened this issue Oct 13, 2020 · 3 comments
Open

Identify schema of the submission object #36

tschaffter opened this issue Oct 13, 2020 · 3 comments
Assignees

Comments

@tschaffter
Copy link
Member

Define a JSON object that includes all the information required for a submission.

Submission:

  • docker_repository
  • docker_digest

Submitted by (not part of the submission object):

  • submitter_id
  • submitter token

@thomasyu888 What else?

@tschaffter
Copy link
Member Author

About Docker images: image needs to be public (any repository) or private image that has been share with one of our service user (image must be stored on Synapse).

@thomasyu888
Copy link
Member

thomasyu888 commented Oct 13, 2020

Here are some that I can think of

  • description
  • features
  • references
  • created_on

Here is an example of what I came up with: https://github.com/Sage-Bionetworks/submission_service/blob/main/openapi_server/openapi/openapi.yaml#L446-L481

@thomasyu888
Copy link
Member

thomasyu888 commented Oct 13, 2020

One of the nice things that Synapse does is that it caches the submission, so if the user decides to delete their docker repo after submission, it can still be ran.

boyleconnor pushed a commit to boyleconnor/nlp-sandbox-schemas that referenced this issue Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants