Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overflow error #76

Closed
sstroobants opened this issue May 26, 2023 · 1 comment
Closed

Overflow error #76

sstroobants opened this issue May 26, 2023 · 1 comment

Comments

@sstroobants
Copy link

https://github.com/nnaisense/evotorch/blame/9d31d59cfcace0c99de59bf59bfbc7ceb55ae11f/src/evotorch/algorithms/cmaes.py#L365
This line results in an overflow error for me. The floor results to zero, thus division by zero.
shouldn't this line be:
int(np.floor(1 / (10 * d * (self.c_1.cpu() + self.c_mu.cpu()))))
@engintoklu
Copy link
Collaborator

Hi @sstroobants !
Thank you for your very useful feedback, and sorry for my very late reaction!
Hopefully this fixes the issue: #86

@engintoklu engintoklu mentioned this issue Aug 3, 2023
Closed
@Higgcz Higgcz closed this as completed Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Higgcz @engintoklu @sstroobants