-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typescript types not available #6
Comments
I released it now (sorry, was off-grid for a while). |
I'm not sure it works properly. Npmjs.org still shows no [TS] badge and neither can I get types to work in my project. @vkuprin there should be No badgeOther repository with the badge |
@FilipChalupa The cleaner approach would be to rewrite everything in types and eliminate .js files altogether. Relying on declaration files can lead to some problems with package types, as we've seen. I will make a patch soon to cover everything in TypeScript. Please bear with me |
@FilipChalupa @noamr Please take a look at my patch #7 |
@vkuprin thank you for your quick response. 🙂 I'm worried that the changes will complicate use without TypeScript. May I suggest an edit? Something like this: https://github.com/vkuprin/use-view-transitions/pull/1. It's not perfect. I've been forced to place a few |
@FilipChalupa Merged your changes! Good point. It's not perfect, but we are gradually improving our hook. Adding test coverage with something like Jest could potentially be our next steps |
@noamr The last CI pipe has failed. Please redeploy or let's push to the master .lock files to avoid pipeline failures. Right now, it's an old version ![]() |
Meanwhile I have created a .d.ts with the following statement: it made the vscode stop complaining about the library installation, hope it work for you guys |
Maybe because 61f31b7 is not released yet.
The text was updated successfully, but these errors were encountered: