Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Serialport version ^10 #154

Open
alana314 opened this issue Jun 6, 2023 · 1 comment
Open

Support Serialport version ^10 #154

alana314 opened this issue Jun 6, 2023 · 1 comment

Comments

@alana314
Copy link

alana314 commented Jun 6, 2023

Thanks for your work on this project!
Serialport post version 10 has some different syntax that causes it not to work with node-dmx. I'll submit a PR in a few for the enttec-usb-dmx-pro.js driver.
alana314 added a commit to alana314/dmx-serial10 that referenced this issue Jun 6, 2023
@alana314
fixes node-dmx#154 use Serialport 10 syntax
d189100
@moerk0
Copy link

moerk0 commented May 23, 2024

Could this pleased be rolled out. As it is open for over a year and we recently updated our project to use serialport^10. And now DMX support is broke due to this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alana314 @moerk0