Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v5.1AuthorizationOptions.scopeBreaking Change #307

Closed
Lordfirespeed opened this issue Jul 24, 2024 · 3 comments
Closed

v5.1AuthorizationOptions.scopeBreaking Change #307

Lordfirespeed opened this issue Jul 24, 2024 · 3 comments

Comments

@Lordfirespeed
Copy link
Contributor

related: #305, #306

Version 5.1 changed the accepted type of AuthorizationOptions.scope from string[] to string, which is a breaking change.
@dhensby
Copy link
Contributor

dhensby commented Jul 24, 2024

introduced in #267

The only sensible approach is to accept both strings and arrays of strings for this argument.

@dhensby dhensby mentioned this issue Jul 24, 2024
Merged
@Lordfirespeed
Copy link
Contributor Author

Resolved by #309

@jankapunkt
Copy link
Member

Will publish this with a new minor release, once we got #314 merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dhensby @jankapunkt @Lordfirespeed