Skip to content

Commit 0661bac

Browse files
committed
doc: add minutes for meeting 25 Oct 2023
Signed-off-by: Michael Dawson <[email protected]>
1 parent 528ba17 commit 0661bac

File tree

1 file changed

+110
-0
lines changed

1 file changed

+110
-0
lines changed

meetings/2023-10-25.md

+110
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,110 @@
1+
# Node.js Technical Steering Committee (TSC) Meeting 2023-10-25
2+
3+
## Links
4+
5+
* **Recording**: <https://www.youtube.com/watch?v=q64U3T54j2s>
6+
* **GitHub Issue**: <https://github.com/nodejs/TSC/issues/1457>
7+
8+
## Present
9+
10+
* Antoine du Hamel @aduh95 (voting member)
11+
* Yagiz Nizipli @anonrig (voting member)
12+
* Benjamin Gruenbaum @benjamingr (voting member)
13+
* Ruben Bridgewater @BridgeAR (voting member)
14+
* Geoffrey Booth @GeoffreyBooth (voting member)
15+
* Joyee Cheung @joyeecheung (voting member)
16+
* Chengzhong Wu @legendecas (voting member)
17+
* Michael Dawson @mhdawson (voting member)
18+
* Moshe Atlow @MoLow (voting member)
19+
* Rafael Gonzaga @RafaelGSS (voting member)
20+
* Richard Lau @richardlau (voting member)
21+
* Robert Nagy @ronag (voting member)
22+
* Ruy Adorno @ruyadorno (voting member)
23+
24+
## Agenda
25+
26+
### Announcements
27+
28+
* Richard - Node.js 20 went LTS on Tuesday, Yay!
29+
30+
### CPC and Board Meeting Updates
31+
32+
* No updates this week
33+
34+
*Extracted from **tsc-agenda** labeled issues and pull requests from the **nodejs org** prior to the meeting.
35+
36+
### nodejs/node
37+
38+
* navigator object breaks projects in v21.0.0 [#50269](https://github.com/nodejs/node/issues/50269)
39+
*Robert - pretty much resolved
40+
* Geoffrey, lessons learned
41+
* we should added more values together, now added the other one
42+
* did not have enough coverage in CITGM, adding Next.js which should help
43+
* Antoine, we should also have a flag to disable?
44+
* Geoffrey, we can just disabled with existing options instead
45+
* Richard, if we added with flag, disabled then set as on, would also backporting and provide
46+
for work around if a problem comes up when there is a problem
47+
48+
* test: set test-fs-watch as flaky [#50250](https://github.com/nodejs/node/pull/50250)
49+
* Michael - would be good to have some sort of minimal requirement
50+
* Joyee - we can set threshold high to start, then we can adjust from there.
51+
Would be good to start high bart to start
52+
* Richard, Marco is working on automation to mark test as flaky, have some reservations as
53+
we need to make sure we come back to fix things. Note that if job is yellow it gets restarted if
54+
you resume a build
55+
* Rafael, if test is flaky for 6 months, we should probably just remove the test
56+
* Robert, also need to consider how people work. Some don’t want things flagged as flaky
57+
as nobody will fix them. But most people just re-run, 80% of collaborators do that. Second
58+
that we should just remove the tests.
59+
* Geoffrey, better way would be to prevent flaky tests from getting in, in the first place. Could
60+
CI run new tests in pipeline to check for flakiness.
61+
* Robert that does not solve current situation
62+
* Yagiz, new collaborator, new contributor, see failures so don’t know that it’s flaky, should
63+
remove that for new collaborators.
64+
* Michael, might be able to change processes to reduce/change what you need to do with
65+
tests.
66+
* Richard, would object to changing the process as see collaborators who land even when
67+
introducing flakes.
68+
* Joyee, do need to capture info about tests that fail, sometimes flakes appeared from bugs and we need historical records about them to have more clues
69+
* Richard, there has been a post on third party flake testing tool
70+
* Michael to open issue to continue discussion in.
71+
72+
* Revert "doc: promote fetch/webstreams from experimental to stable" [#49867](https://github.com/nodejs/node/pull/49867)
73+
* Richard, problem is that fetch does not fit into our stability matrix
74+
* Original suggestion was that it should be experimental. We marked it as stable in 21.
75+
* Robert, we could have undici do a SemVer major, and don’t do those in Node.js minor
76+
Releases, Don’t see any reason to have Node.js have the latest and greatest.
77+
* Robert, other question is WebStreams, but level of activity seems lower there.
78+
* Yagiz, URL also makes breaking changes, but because nobody uses origin not an issue.
79+
* Next step, Robert will make his proposal and we’ll see how that goes.
80+
81+
* tools: add package-lock when installing npm dependency [#49747](https://github.com/nodejs/node/pull/49747)
82+
* Michael gave overview
83+
* Some discussion
84+
85+
* The env var `NODE_V8_COVERAGE` intermittently causes the process to hang [#49344](https://github.com/nodejs/node/issues/49344)
86+
* Colin mentioned that Undici work around has reduced the incidence
87+
* Rafael, ongoing investigation no solution
88+
89+
* Support for file-system based persistent code cache in user-land module loaders [#47472](https://github.com/nodejs/node/issues/47472)
90+
* Joyee, popular package that monkey patches loader to provide persistent cache to speed up
91+
loading modules. A feature like this would speed up 2nd run.
92+
* Some concerns about security, if persisted to disk, possible for attacker to corrupt cache.
93+
Asking the TSC to discuss if this is a big enough concern to block the feature.
94+
* Ran out of time so leaving on the agenda for more discussion next time.
95+
96+
### nodejs/admin
97+
98+
* Have a mascot [#828](https://github.com/nodejs/admin/issues/828)
99+
* Update from OpenJS staff covered in private session
100+
101+
* Create `nodejs/socket` repository for Node.js implementation of Cloudflare's Socket API [#826](https://github.com/nodejs/admin/issues/826)
102+
* Discussed last time, skip as we ran out of time
103+
104+
## Strategic Initiatives
105+
106+
## Upcoming Meetings
107+
108+
* **Node.js Project Calendar**: <https://nodejs.org/calendar>
109+
110+
Click `+GoogleCalendar` at the bottom right to add to your own Google calendar.

0 commit comments

Comments
 (0)