Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Orka template updates #3906

Merged
merged 4 commits into from
Sep 16, 2024
Merged

Orka template updates #3906

merged 4 commits into from
Sep 16, 2024

Conversation

UlisesGascon
Copy link
Member

@UlisesGascon UlisesGascon commented Sep 13, 2024 •
edited
Loading

Main Changes

  • Ensure Homebrew environment is set up in the shell profile (01f78be)
  • Add xz as dependency (8628fe3)
  • Add xcode version information (26f4f34)
  • Add tap2junit as dependency (a976199)

Context

Related #3686

@UlisesGascon UlisesGascon marked this pull request as ready for review September 13, 2024 09:02
@UlisesGascon UlisesGascon self-assigned this Sep 13, 2024
@UlisesGascon UlisesGascon requested a review from a team September 13, 2024 09:02
@targos
Copy link
Member

targos commented Sep 13, 2024

Is there no way to share common parts of the hcl files? It must be annoying to always do the same thing 4 times.

@UlisesGascon UlisesGascon mentioned this pull request Sep 16, 2024
Open
12 tasks
@UlisesGascon
Copy link
Member Author

Is there no way to share common parts of the hcl files? It must be annoying to always do the same thing 4 times.

Agree, I was expecting more differences between the templates. After the migration I will work on this unification :)

@UlisesGascon UlisesGascon merged commit 3f299e3 into nodejs:main Sep 16, 2024
2 checks passed
@UlisesGascon UlisesGascon deleted the feat/jenkins-missing-dependencies branch September 16, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

Assignees

@UlisesGascon UlisesGascon

Labels
orka packer platform:osx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@UlisesGascon @targos