-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can we get hooked up to the node.js CI infrastructure? #508
Comments
/cc @nodejs/build |
Yes in general. Some of the arm buildbots are pretty slow though.
At the moment: manually. |
If they run in parallel, I don't think it should be too much of a problem. If it is less than five minutes, it should probably be fine. If we end up only doing occasional one-off builds on a big-endian machine, the speed should be of no concern. Also, building NAN's test suite should be a far cry from building V8 + node.js + libuv. EDIT: |
See also #958. |
As @bnoordhuis mentioned, it might be possible to get us hooked up to the node.js CI infrastructure.
In general, this could be very nice.
From a personal point of view, my main concerns are with ease of use and speed.
Are CI builds done automatically or manually in node.js?
If they are started manually, the second point above is less important. We could then rely on the current setup for everyday use and do occasional manual checks on a big-endian machine before publishing new versions or merging PRs which might run into endianness problems.
I guess a manual build setup would be easier for the node.js infrastructure team to pull off and would produce less overhead and noise.
/cc @rvagg
The text was updated successfully, but these errors were encountered: