Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagged releases and commits are not signed #881

Open
braydonf opened this issue Dec 26, 2019 · 2 comments
Open

Tagged releases and commits are not signed #881

braydonf opened this issue Dec 26, 2019 · 2 comments

Comments

@braydonf
Copy link

The last signed version I was able to find was https://github.com/nodejs/nan/releases/tag/v1.5.1 the latest tag is not signed https://github.com/nodejs/nan/releases/tag/v2.14.0.

@mkrufky
Copy link
Collaborator

mkrufky commented Apr 22, 2020

@kkoopa I believe this can be fixed in future releases by handling the version bump in a separate branch and merging that branch into master before release, triggering github to mark both the merge commit and release as "verified"

@braydonf
Copy link
Author

braydonf commented Apr 22, 2020

The tag can be signed using:

git tag -s v2.14.1 -m v2.14.1

And git can be configured to sign each commit with a ~/.gitconfig including:

[user]
  email = <email>
  name = <name>
  signingKey = <fingerprint>
[commit]
  gpgSign = true
[gpg]
  program = gpg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants