Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why do these two examples need a static FunctionReference? #169

Open
seishun opened this issue Dec 18, 2020 · 0 comments
Open

Why do these two examples need a static FunctionReference? #169

seishun opened this issue Dec 18, 2020 · 0 comments

Comments

@seishun
Copy link

seishun commented Dec 18, 2020

Napi::FunctionReference NativeAddon::constructor;

Napi::FunctionReference NativeEmitter::constructor;

It's not referred anywhere other than the Init function and having an "immortal" Napi::FunctionReference seems unnecessary since the constructor isn't invoked from native code.

Curiously, these two examples were untouched by dc86a66, which replaced the usage of a static FunctionReference with instance data in examples that do need to keep the constructor alive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant