You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.
This commit added support for a new API vm.script.createCachedData.
This calls chakrashim's CreateCachedData, which is not currently hooked up.
A few things need to happen here:
We need to wire up CreateCachedData to call Jsrt's JsSerialize - this will serialize the given script into an array buffer.
We need to enure that Node's node_contextify.cc CreateCachedData is doing the "right thing" with this as a return value.
We need to ensure that chakrashim's ScriptCompiler::Source is doing the right thing with the cached_data param if passed in. That is, if specified, we expect cached_data to be a buffer produced as from a call to JsSerialize, and we should use it appropriately. Currently, Source just drops this.
We need to re-enable the test test/parallel/test-vm-createcacheddata.js, which is currently disabled for node-chakracore.
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This commit added support for a new API
vm.script.createCachedData
.This calls chakrashim's CreateCachedData, which is not currently hooked up.
A few things need to happen here:
CreateCachedData
to call Jsrt'sJsSerialize
- this will serialize the given script into an array buffer.CreateCachedData
is doing the "right thing" with this as a return value.ScriptCompiler::Source
is doing the right thing with thecached_data
param if passed in. That is, if specified, we expect cached_data to be a buffer produced as from a call to JsSerialize, and we should use it appropriately. Currently, Source just drops this.test/parallel/test-vm-createcacheddata.js
, which is currently disabled for node-chakracore.The text was updated successfully, but these errors were encountered: