diagnostics_channel: add diagnostics channels for web locks#62123
diagnostics_channel: add diagnostics channels for web locks#62123nodejs-github-bot merged 2 commits intonodejs:mainfrom
Conversation
c92cc75 to
8ce0c9b
Compare
Codecov Reportβ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #62123 +/- ##
==========================================
+ Coverage 88.84% 89.65% +0.81%
==========================================
Files 674 676 +2
Lines 204957 206604 +1647
Branches 39309 39554 +245
==========================================
+ Hits 182087 185232 +3145
+ Misses 15088 13502 -1586
- Partials 7782 7870 +88
π New features to boost your workflow:
|
Commit Queue failed- Loading data for nodejs/node/pull/62123 β Done loading data for nodejs/node/pull/62123 ----------------------------------- PR info ------------------------------------ Title diagnostics_channel: add diagnostics channels for web locks (#62123) Author Ilyas Shabi <ilyasshabi94@gmail.com> (@IlyasShabi) Branch IlyasShabi:ishabi/web-lock-dc -> nodejs:main Labels author ready, needs-ci, diagnostics_channel Commits 2 - diagnostics_channel: add diagnostics channels for web locks - update dc locks documentation Committers 1 - ishabi <ilyasshabi94@gmail.com> PR-URL: https://github.com/nodejs/node/pull/62123 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/62123 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> -------------------------------------------------------------------------------- βΉ This PR was created on Thu, 05 Mar 2026 22:09:57 GMT β Approvals: 2 β - Stephen Belanger (@Qard): https://github.com/nodejs/node/pull/62123#pullrequestreview-3905275680 β - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/62123#pullrequestreview-3922878021 β Last GitHub CI successful βΉ Last Full PR CI on 2026-03-10T21:16:18Z: https://ci.nodejs.org/job/node-test-pull-request/71680/ - Querying data for job/node-test-pull-request/71680/ β Build data downloaded β Last Jenkins CI successful -------------------------------------------------------------------------------- β No git cherry-pick in progress β No git am in progress β No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD β origin/main is now up-to-date - Downloading patch for 62123 From https://github.com/nodejs/node * branch refs/pull/62123/merge -> FETCH_HEAD β Fetched commits as a936d8968f9d..ca7fc4d07a6b -------------------------------------------------------------------------------- Auto-merging doc/api/diagnostics_channel.md [main 3a1f9731bf] diagnostics_channel: add diagnostics channels for web locks Author: ishabi <ilyasshabi94@gmail.com> Date: Thu Mar 5 22:42:29 2026 +0100 3 files changed, 270 insertions(+), 3 deletions(-) create mode 100644 test/parallel/test-diagnostics-channel-web-locks.js Auto-merging doc/api/diagnostics_channel.md [main e77c6fca33] update dc locks documentation Author: ishabi <ilyasshabi94@gmail.com> Date: Tue Mar 10 15:26:32 2026 +0100 1 file changed, 2 insertions(+), 2 deletions(-) β Patches applied There are 2 commits in the PR. Attempting autorebase. (node:462) [DEP0190] DeprecationWarning: Passing args to a child process with shell option true can lead to security vulnerabilities, as the arguments are not escaped, only concatenated. (Use `node --trace-deprecation ...` to show where the warning was created) Rebasing (2/4) Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- diagnostics_channel: add diagnostics channels for web lockshttps://github.com/nodejs/node/actions/runs/23097632174 |
|
Landed in 1989f4d |
This PR adds diagnostics channels support for
locks.request()giving visibility into the lock request lifecycle.Four channels are emitted:
locks.request.startwhen a request beginslocks.request.grantwhen the lock is grantedlocks.request.misswhen the lock is not immediately availablelocks.request.endwhen the request finishes