Typo in importing process in multiple files in lib/internal/streams

[ankitzm]

I was building an app where I imported @toruslabs/base-controllers. The @toruslabs/base-controllers have readable-stream as a dev-dependency as listed in the package.json file.

My node version: v18.14.1

Problem

When I ran my code, it threw the below error. Clearly, the error was because it couldn't find any process/ module as there is no such thing.

The error was fixed when I changed all the process/ to process. As I was checking through the readable-stream repository, I found multiple typos in the process module in the repo. This might be breaking a lot of apps and I think this can be easily fixed with a single PR.

Solution

The typo needs to be fixed in these files 👇

I would love to work on the issue, let me know if I missed something.
Thank You

[rluvaton]

looking at the history it looks like this was intended:

• fix: use workaround loading process-shim for browserify #497

[vweevers]

It's an old trick to tell Node.js (and bundlers that follow the same require() algorithm) to load an npm package instead of a core module.

Might be an issue with Vite specifically. We don't directly test Vite (in dev mode) but we do test Rollup here (which is what Vite uses in production mode):

readable-stream/test/browser/runner-prepare.mjs

Lines 94 to 97 in 268229d

	case 'rollup':
	await run('rollup -c test/browser/fixtures/rollup.browser.config.mjs')
	await run('rollup -c test/browser/fixtures/rollup.node.config.mjs')
	break

[ankitzm]

Ohh, thanks for reviewing @rluvaton and @vweevers.
Will try it using vite in production mode and update here. Thanks.

[BryanWallin]

I'm seeing this issue when trying to use archiver (which includes this project under the hood) when running a vanilla Node.js script on version 20.2.0:

Error: Cannot find module 'process/'
Require stack:
- C:\Users\user\Documents\GitHub\project\packages\scripts\zip-lambdas\node_modules\readable-stream\lib\internal\streams\end-of-stream.js
- C:\Users\user\Documents\GitHub\project\packages\scripts\zip-lambdas\node_modules\readable-stream\lib\internal\streams\operators.js
- C:\Users\user\Documents\GitHub\project\packages\scripts\zip-lambdas\node_modules\readable-stream\lib\stream.js
- C:\Users\user\Documents\GitHub\project\packages\scripts\zip-lambdas\node_modules\readable-stream\lib\ours\index.js
- C:\Users\user\Documents\GitHub\project\packages\scripts\zip-lambdas\node_modules\archiver-utils\index.js

It appears the appended / no longer works in Node.js 20? This is our usage of it:

import archiver from 'archiver';

[MMesch]

I ran into the same problem when working on an Obsidian plugin. It builds fine but crashes at runtime in the Obsidian electron desktop app because it can't find process/. I'm using esbuild.

https://forum.obsidian.md/t/cant-enable-plugin-depending-on-readable-stream/84235

Not sure how to work around this yet. Looking forward to ideas.

[jonluca]

Adding in process using yarn add process worked for now with esbuild, but it feels like this is going to break.