Skip to content

Commit 7e5cf25

Browse files
committed
Fix paginated tests, refs caged/octo#20
1 parent 6ea9eb6 commit 7e5cf25

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed

components/GetStargazers.coffee

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,11 @@ class GetStargazers extends noflo.AsyncComponent
2121
api = octo.api()
2222
api.token @token if @token
2323
request = api.get "/repos/#{repository}/stargazers"
24+
request.perpage 30
2425
request.on 'success', (res) =>
26+
unless res.body.length
27+
@outPorts.out.disconnect()
28+
return
2529
@outPorts.out.beginGroup repository
2630
@outPorts.out.send user for user in res.body
2731
@outPorts.out.endGroup()

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
},
1919
"dependencies": {
2020
"noflo": "0.5.x",
21-
"octo": "0.1.x",
21+
"octo": "git://github.com/bergie/octo.git#patch-2",
2222
"atob": "~1.1.0",
2323
"btoa": "~1.1.1"
2424
},

test/GetStargazers.coffee

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,20 +16,20 @@ setupComponent = ->
1616
exports['test reading for valid repo'] = (test) ->
1717
[c, repo, token, out, err] = setupComponent()
1818

19-
expected = 200
19+
expected = 100
2020
received = 0
2121
failed = false
2222
out.on 'data', (data) ->
2323
received++
2424
test.ok data, 'We should receive user objects'
2525
test.ok data.login, 'Users should have logins'
2626
out.once 'disconnect', ->
27-
test.ok (received >= expected), 'We should get at least 200 stargazers'
27+
test.ok (received >= expected), 'We should get at least 100 stargazers'
2828
test.done() unless failed
2929
err.once 'data', (data) ->
3030
test.ok false, "We should have gotten a result. Received #{received} before this"
3131
failed = true
3232
test.done()
3333

3434
token.send process.env.GITHUB_API_TOKEN
35-
repo.send 'noflo/noflo'
35+
repo.send 'noflo/noflo-ui'

0 commit comments

Comments
 (0)