Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors with a simple net #4

Open
oleksandr opened this issue May 28, 2014 · 7 comments
Open

Errors with a simple net #4

oleksandr opened this issue May 28, 2014 · 7 comments

Comments

@oleksandr
Copy link

Example of a net:

P1(C1) OUT -> IN P2(C2)
P2 OUT -> IN P3(C3)

Result:

Invariant Violation: replaceState(...): Cannot update during an existing state transition (such as within render). This could potentially cause an infinite loop so it is forbidden.

@forresto
Copy link
Member

I'll update visualize to use the new version of the-graph (custom element) and klay (autolayout) next week. This should fix these issues.

@forresto
Copy link
Member

forresto commented Jun 2, 2014

It looks like https://github.com/noflo/fbp doesn't parse P1 as a valid component name.

POne(C1) OUT -> IN PTwo(C2)
PTwo OUT -> IN PThree(C3)

works.

@forresto
Copy link
Member

forresto commented Jun 2, 2014

Actually,

P1(C1) OUT -> IN P2(C2)
P2() OUT -> IN P3(C3)

and

P1(C1) OUT -> IN p2(C2)
p2 OUT -> IN P3(C3)

work as well. @bergie something in the parser that keeps @oleksandr's second line (
P2 OUT -> IN P3(C3)
) from working ?

@jpaulm
Copy link

jpaulm commented Sep 23, 2014

@oleksandr I just tried your original text, and got a message saying conn.src is undefined .

Added [0] after the OUT in the 2nd line, and got edges.forEach is not a function . !!!

@bergie
Copy link
Member

bergie commented Sep 23, 2014

Sounds like a bug in the .fbp parser. I'll transfer that example to a unit test a bit later

@jpaulm
Copy link

jpaulm commented Oct 2, 2014

@bergie Should this be posted under https://github.com/noflo/fbp/issues ? If so, we could post it there and close this one.

@oleksandr
Copy link
Author

@bergie In the Go's version of FBP parser using PEG I've noticed that order of expressions in the grammar matters :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants