Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is there any plans to support "distance" weights and "predict_proba" method for KNearestNeighbour ? #39

Open
KMKnation opened this issue Nov 16, 2018 · 2 comments
Open

Is there any plans to support "distance" weights and "predict_proba" method for KNearestNeighbour ? #39

KMKnation opened this issue Nov 16, 2018 · 2 comments
Labels
1.0.0 Issue covered in release 1.0.0 enhancement question

Comments

@KMKnation
Copy link

Currently i am generating my java file with training "uniform" weights but i want to generate java code with the "distance" weights.

When i am trying to generate it with the "distance" weight it generates NotImplementedError.

If i have to implement it on my own, How can i implement ?.

Any idea can help me. :)
@nok
Copy link
Owner

nok commented Jan 3, 2019

In general the predict_proba method is planned for all estimators and languages.

After a quick check I ended in extmath.py#L410-L480 (from sklearn/neighbors/classification.py#L158 and sklearn/neighbors/classification.py#L165) which is used to compute the weighted result in a KNN. These are the places I would use to reimplement the logic in the target programming language.

@nok nok added the 1.0.0 Issue covered in release 1.0.0 label Aug 10, 2019
@KMKnation
Copy link
Author

is there any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.0.0 Issue covered in release 1.0.0 enhancement question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nok @KMKnation