From 6ebaa3fd6c558e87914f4c2379e85e1430a4fcdd Mon Sep 17 00:00:00 2001 From: mgiannopoulos24 <79588074+mgiannopoulos24@users.noreply.github.com> Date: Sun, 28 Dec 2025 02:01:05 +0200 Subject: [PATCH] Fixed tab focus issue --- demos/4006-tab-focus-fix.html | 167 ++++++++++++++++++++++++++++++++++ demos/index.html | 1 + src/modules/a11y/a11y.mjs | 122 ++++++++++++++++++++++++- 3 files changed, 289 insertions(+), 1 deletion(-) create mode 100644 demos/4006-tab-focus-fix.html diff --git a/demos/4006-tab-focus-fix.html b/demos/4006-tab-focus-fix.html new file mode 100644 index 000000000..049296a96 --- /dev/null +++ b/demos/4006-tab-focus-fix.html @@ -0,0 +1,167 @@ + + + + + + Swiper - Tab Focus Fix Test + + + + +

Tab Focus Fix Test - Issue #4006

+

Use the Tab key to navigate through the links in the slides. The slider should not break when a link gets focused.

+ + +
+
+
+

Slide 1

+

This slide contains a link:

+ Link in Slide 1 +
+
+

Slide 2

+

This slide contains multiple links:

+ First Link in Slide 2
+ Second Link in Slide 2 +
+
+

Slide 3

+

This slide contains a button:

+ +
+
+

Slide 4

+

This slide contains a link that should trigger navigation:

+ Link in Slide 4 +
+
+

Slide 5

+

Another link here:

+ Link in Slide 5 +
+
+

Slide 6

+

Final slide with a link:

+ Link in Slide 6 +
+
+ +
+ +
+
+
+ +
+

Test Instructions:

+
    +
  1. Click on the slider or press Tab to start tabbing through the page
    2. +
  2. When you tab to a link inside a slide, the slider should automatically navigate to that slide
    3. +
  3. The slider display should NOT break - slides should remain properly aligned
    4. +
  4. Continue tabbing through all links to verify the fix works for all slides
    5. +
+

Expected behavior: The slider should smoothly navigate to the slide containing the focused link without breaking the layout.

+

Previous bug: When a link got focus, the browser would scroll the container, changing scrollLeft and breaking the slider display.

+
+ + + + + + + + + + diff --git a/demos/index.html b/demos/index.html index 7a60b2bbc..0dfdff85c 100644 --- a/demos/index.html +++ b/demos/index.html @@ -61,6 +61,7 @@

Swiper demos

  • 430-slideable-menu
  • 440-change-direction
  • 450-watchSlidesVisibility
    • +
  • 4006-tab-focus-fix
    • diff --git a/src/modules/a11y/a11y.mjs b/src/modules/a11y/a11y.mjs index 50486a41d..e77e4e79e 100644 --- a/src/modules/a11y/a11y.mjs +++ b/src/modules/a11y/a11y.mjs @@ -37,6 +37,10 @@ export default function A11y({ swiper, extendParams, on }) { let preventFocusHandler; let focusTargetSlideEl; let visibilityChangedTimestamp = new Date().getTime(); + let savedScrollLeft = 0; + let savedScrollTop = 0; + let isRestoringScroll = false; + let scrollRestoreTimeout = null; function notify(message) { const notification = liveRegion; @@ -242,6 +246,104 @@ export default function A11y({ swiper, extendParams, on }) { visibilityChangedTimestamp = new Date().getTime(); }; + const restoreScrollPosition = () => { + if (!isRestoringScroll) return; + if (swiper.isHorizontal()) { + if (swiper.params.cssMode && swiper.el.scrollLeft !== savedScrollLeft) { + swiper.el.scrollLeft = savedScrollLeft; + } + if (swiper.wrapperEl.scrollLeft !== savedScrollLeft) { + swiper.wrapperEl.scrollLeft = savedScrollLeft; + } + } else { + if (swiper.params.cssMode && swiper.el.scrollTop !== savedScrollTop) { + swiper.el.scrollTop = savedScrollTop; + } + if (swiper.wrapperEl.scrollTop !== savedScrollTop) { + swiper.wrapperEl.scrollTop = savedScrollTop; + } + } + }; + + const handleScroll = () => { + if (isRestoringScroll) { + restoreScrollPosition(); + } + }; + + const handleFocusIn = (e) => { + if (swiper.a11y.clicked || !swiper.params.a11y.scrollOnFocus) return; + if (new Date().getTime() - visibilityChangedTimestamp < 100) return; + + const slideEl = e.target.closest(`.${swiper.params.slideClass}, swiper-slide`); + if (!slideEl || !swiper.slides.includes(slideEl)) return; + + // Check if the focused element is a focusable element (link, button, etc.) + const focusableElements = ['A', 'BUTTON', 'INPUT', 'SELECT', 'TEXTAREA', 'AREA']; + const isFocusableElement = focusableElements.includes(e.target.tagName) || + e.target.hasAttribute('tabindex') || + e.target.isContentEditable; + + if (!isFocusableElement) return; + + if (e.sourceCapabilities && e.sourceCapabilities.firesTouchEvents) return; + + // Always save and restore scroll position to prevent browser scroll from breaking the slider + // Save current scroll positions before browser scrolls + if (swiper.isHorizontal()) { + savedScrollLeft = swiper.params.cssMode ? swiper.el.scrollLeft : swiper.wrapperEl.scrollLeft; + } else { + savedScrollTop = swiper.params.cssMode ? swiper.el.scrollTop : swiper.wrapperEl.scrollTop; + } + + // Enable scroll restoration + isRestoringScroll = true; + + // Clear any existing timeout + if (scrollRestoreTimeout) { + clearTimeout(scrollRestoreTimeout); + } + + // Restore scroll position immediately and multiple times to catch browser scroll + restoreScrollPosition(); + requestAnimationFrame(() => { + restoreScrollPosition(); + requestAnimationFrame(() => { + restoreScrollPosition(); + }); + }); + + // Disable scroll restoration after a short time + scrollRestoreTimeout = setTimeout(() => { + isRestoringScroll = false; + }, 100); + + focusTargetSlideEl = slideEl; + const isActive = swiper.slides.indexOf(slideEl) === swiper.activeIndex; + const isVisible = + swiper.params.watchSlidesProgress && + swiper.visibleSlides && + swiper.visibleSlides.includes(slideEl); + + // Only navigate to slide if it's not already active or visible + if (!isActive && !isVisible) { + // Navigate to the correct slide + requestAnimationFrame(() => { + if (preventFocusHandler) return; + if (swiper.params.loop) { + swiper.slideToLoop( + swiper.getSlideIndexWhenGrid(parseInt(slideEl.getAttribute('data-swiper-slide-index'))), + 0, + ); + } else { + swiper.slideTo(swiper.getSlideIndexWhenGrid(swiper.slides.indexOf(slideEl)), 0); + } + + preventFocusHandler = false; + }); + } + }; + const handleFocus = (e) => { if (swiper.a11y.clicked || !swiper.params.a11y.scrollOnFocus) return; if (new Date().getTime() - visibilityChangedTimestamp < 100) return; @@ -351,10 +453,16 @@ export default function A11y({ swiper, extendParams, on }) { // Tab focus const document = getDocument(); document.addEventListener('visibilitychange', onVisibilityChange); - swiper.el.addEventListener('focus', handleFocus, true); + // Use focusin to catch focus events before browser scrolls + swiper.el.addEventListener('focusin', handleFocusIn, true); swiper.el.addEventListener('focus', handleFocus, true); swiper.el.addEventListener('pointerdown', handlePointerDown, true); swiper.el.addEventListener('pointerup', handlePointerUp, true); + // Listen for scroll events to restore scroll position when browser scrolls due to focus + swiper.wrapperEl.addEventListener('scroll', handleScroll, { passive: true }); + if (swiper.params.cssMode) { + swiper.el.addEventListener('scroll', handleScroll, { passive: true }); + } }; function destroy() { if (liveRegion) liveRegion.remove(); @@ -380,10 +488,22 @@ export default function A11y({ swiper, extendParams, on }) { document.removeEventListener('visibilitychange', onVisibilityChange); // Tab focus if (swiper.el && typeof swiper.el !== 'string') { + swiper.el.removeEventListener('focusin', handleFocusIn, true); swiper.el.removeEventListener('focus', handleFocus, true); swiper.el.removeEventListener('pointerdown', handlePointerDown, true); swiper.el.removeEventListener('pointerup', handlePointerUp, true); } + // Remove scroll listeners + if (swiper.wrapperEl) { + swiper.wrapperEl.removeEventListener('scroll', handleScroll, { passive: true }); + } + if (swiper.params.cssMode && swiper.el && typeof swiper.el !== 'string') { + swiper.el.removeEventListener('scroll', handleScroll, { passive: true }); + } + // Clear timeout + if (scrollRestoreTimeout) { + clearTimeout(scrollRestoreTimeout); + } } on('beforeInit', () => {