Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualize systems with topology information only #139

Open
Bernadette-Mohr opened this issue Dec 19, 2024 · 3 comments · May be fixed by #145
Open

Visualize systems with topology information only #139

Bernadette-Mohr opened this issue Dec 19, 2024 · 3 comments · May be fixed by #145
Assignees
Labels
enhancement New feature or request

Comments

@Bernadette-Mohr
Copy link
Collaborator

Currently, systems are only visualized if a trajectory is part of the uploaded data. Since we only display a single snapshot, providing a coordinate file, e.g., gro or pdb, should be enough for nomad to create the visualization.

@Bernadette-Mohr Bernadette-Mohr self-assigned this Dec 19, 2024
@Bernadette-Mohr Bernadette-Mohr added the enhancement New feature or request label Dec 19, 2024
@JFRudzinski
Copy link
Collaborator

I think this should be rather straightforward:

We should add some more logic to the designation of the trajectory (or structure) file to be used with the MDAnalysis parser, see Block around Line 1694.

I would suggest creating a function find_trajectory_files(), which executes the current block and logic, but then also looks for pdb, gro, etc. if trr and xtc are not found. We have to define an prioritization ordering, I would say: trr, xtc, pdb, gro, ... (I prioritized pdb above gro because it can also hold a trajectory, but maybe this is not right). Other formats that people use with Gromacs?

@Bernadette-Mohr
Copy link
Collaborator Author

Bernadette-Mohr commented Jan 13, 2025

A small update:

https://userguide.mdanalysis.org/stable/universe.html

If only a single file is provided, MDAnalysis tries to read both topology and trajectory information from it.

  • Passing only a *.gro file to MDAnalysis generates a universe with topology information and a single trajectory frame
  • Same for passing only a PDB file
  • *.gro and PDB are treated as both trajectory and topology formats by MDAnalysis, so this might not hold for other topology formats.

I would suggest making sure that when we generate the MDAnalysis universe, we use the keywords (topology=..., trajectory=...) to make it very clear what kind of information is passed to the current instance.

@JFRudzinski
Copy link
Collaborator

@Bernadette-Mohr Make sure to follow up HERE once this is addressed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants