From 4dae8fd97da44dadc4916d3f10d66180b6d65cb4 Mon Sep 17 00:00:00 2001 From: Andrew Beveridge Date: Mon, 18 May 2026 19:59:30 -0400 Subject: [PATCH] fix: use Name form for Postmark sender in health workflows MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit dawidd6/action-send-mail@v3 only treats the `from:` input as a full mailbox if it matches `Name `; otherwise it builds `"" <>`. Our workflows passed a bare `admin@nomadkaraoke.com` with `username:` set to the Postmark server token, so the action constructed a sender header of `"admin@nomadkaraoke.com" <>` — which Postmark rejected with `501 5.1.7 Bad sender address syntax`, silently dropping the only alert channel for the scheduled health checks. Wrap the sender in `"Name "` so getFrom() short-circuits and the header lands as a real mailbox. SendGrid happened to be lenient about this; Postmark is not. Co-Authored-By: Claude Opus 4.7 (1M context) --- .github/workflows/decide-health.yml | 2 +- .github/workflows/flacfetch-health.yml | 2 +- .github/workflows/gen-health.yml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/decide-health.yml b/.github/workflows/decide-health.yml index c954e82..aae01a3 100644 --- a/.github/workflows/decide-health.yml +++ b/.github/workflows/decide-health.yml @@ -115,7 +115,7 @@ jobs: password: ${{ secrets.POSTMARK_SERVER_TOKEN }} subject: "HEALTH FAILED - Karaoke Decide #${{ github.run_number }}" to: andrew@beveridge.uk - from: admin@nomadkaraoke.com + from: "Karaoke Decide Health " body: | Production health check failed for Karaoke Decide. diff --git a/.github/workflows/flacfetch-health.yml b/.github/workflows/flacfetch-health.yml index 5900ae2..2c04b5d 100644 --- a/.github/workflows/flacfetch-health.yml +++ b/.github/workflows/flacfetch-health.yml @@ -115,7 +115,7 @@ jobs: password: ${{ secrets.POSTMARK_SERVER_TOKEN }} subject: "HEALTH FAILED - Flacfetch Audio Service #${{ github.run_number }}" to: andrew@beveridge.uk - from: admin@nomadkaraoke.com + from: "Flacfetch Health " body: | Production health check failed for Flacfetch audio service. diff --git a/.github/workflows/gen-health.yml b/.github/workflows/gen-health.yml index 9ccef53..1872d6e 100644 --- a/.github/workflows/gen-health.yml +++ b/.github/workflows/gen-health.yml @@ -113,7 +113,7 @@ jobs: password: ${{ secrets.POSTMARK_SERVER_TOKEN }} subject: "HEALTH FAILED - Karaoke Gen #${{ github.run_number }}" to: andrew@beveridge.uk - from: admin@nomadkaraoke.com + from: "Karaoke Gen Health " body: | Production health check failed for Karaoke Gen.