Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make r0 = Node? #4

Open
nominolo opened this issue Jan 10, 2012 · 0 comments
Open

Make r0 = Node? #4

nominolo opened this issue Jan 10, 2012 · 0 comments

Comments

@nominolo
Copy link
Owner

There's a lot of potential for off-by-one errors in the current code. In the interpreter R0 is at base[0], but in the codegen it is at [rbp + 8]. A cleaner solution is probably to always have r0 = Node. That way we also no longer need a special bytecode instruction for adding free variables (it's just loading a field from r0). Potential issues:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant