Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using hashabler to support hashing arbitrary types? #10

Open
jberryman opened this issue Jan 19, 2016 · 1 comment
Open

Consider using hashabler to support hashing arbitrary types? #10

jberryman opened this issue Jan 19, 2016 · 1 comment

Comments

@jberryman
Copy link

Would you be interested in merging changes that permitted hashing of arbitrary Hashable types from my hashabler package? The resulting hash functions would look more or less the same. This would allow hashing of many more instances, and take care of cross-platform consistency for you, etc.

I'm not sure when I'd be able to get to this, but I wanted to float the idea first. Let me know if you're interested and would like more details about what that might look like.

@nominolo
Copy link
Owner

nominolo commented Feb 1, 2016

I'm interested in principle, yes.

I'm not sure how important Murmur2 is these days. I'd prefer if it could be backwards-compatible (e.g., by putting the new functions in a different module.) From a quick scan, it looks like there's just a few new top-level functions required?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants