Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mistake in Line 277 #58

Closed
KGBRUS1 opened this issue May 10, 2023 · 5 comments
Closed

Mistake in Line 277 #58

KGBRUS1 opened this issue May 10, 2023 · 5 comments

Comments

@KGBRUS1
Copy link

KGBRUS1 commented May 10, 2023

Dear Nopnp2002,

i think there is a mistake in Line 277 " GPIOA->ODR |= 0x1UL << 12; // PA12 Upll-up"

The PA12 is the TX pin, i think that the RX pin (PA11) must be usesed in this line

simulat to GPIOB->ODR |= 0x1UL << 8; // PB8 Upll-up (this is RX Pin

best regards

Kay

by the way, thanks for your Sketch!
@nopnop2002
Copy link
Owner

nopnop2002 commented May 10, 2023 •
edited
Loading

i think there is a mistake in Line 277 " GPIOA->ODR |= 0x1UL << 12; // PA12 Upll-up"

which subdirectory?

@KGBRUS1
Copy link
Author

KGBRUS1 commented May 10, 2023

Sorry:

Arduino-STM32-CAN/stm32f103
/stm32f103.ino

@nopnop2002
Copy link
Owner

It looks like a bug.
Test then fix.
Thanks for the report.

@KGBRUS1
Copy link
Author

KGBRUS1 commented May 10, 2023

Thanks for your excelent work! i never get CAN and Blue Pill running without your sketch!

@nopnop2002
Copy link
Owner

Fixed.

thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nopnop2002 @KGBRUS1