Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaling is applied to the normals descriptor in SimilarityTransformation class #554

Open
simonpierredeschenes opened this issue Jan 19, 2024 · 0 comments

Comments

@simonpierredeschenes
Copy link
Collaborator

In the inPlaceCompute function of SimilarityTransformation, in TransformationsImpl.cpp, the whole top left submatrix of the TransformationParameters is applied to the normals descriptor. However, if this transformation contains non-uniform scaling for the different axes, this will cause issues in a lot of different places in libpointmatcher.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant