Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pls stop #61

Open
Announcement opened this issue Feb 23, 2018 · 8 comments
Open

pls stop #61

Announcement opened this issue Feb 23, 2018 · 8 comments

Comments

@Announcement
Copy link

why is it a good idea to enable "developers" to continue to use software that is long past is lifespan, and probably a giant security threat?

@RyanZim
Copy link
Contributor

RyanZim commented Feb 23, 2018

@Announcement I'm not sure I understand?

@jmar777
Copy link

jmar777 commented Feb 23, 2018

@Announcement it's true that more recent versions of node are starting to lessen the utility of this module, but there are certainly still valid use cases for people running versions prior to v8.x.

Regarding this module being "probably a giant security threat", could you expand on that? That's a pretty serious assertion.

@Announcement
Copy link
Author

Announcement commented Feb 23, 2018

what i'm asking is, there are probably very valid reasons that this is still in existence, but i just can't come up with any realistic AND reasonable ones.
maybe y'all can help me understand?

@RyanZim
well today in freenode##javascript i came across a guy running an ancient version of iojs in product; still developing on it to this very moment because he doesn't want to learn the new api.

security

@jmar777
you could basically go down the list of security patches since whatever year, and i assume none of them are included (although iojs does have an unfamiliar version bump and i'm not sure if the api has changed as well or what's going on there...)

on the otherhand

although, half way through writing this i did realize something. on the other hand is if we went the other route, and let him use the old api/usage on the newer version of node that would be very useful.

@jmar777
Copy link

jmar777 commented Feb 23, 2018

@Announcement Apologies if I'm missing something, but are you under the impression that this project is io.js, perhaps?

@Announcement
Copy link
Author

no, it's a library that makes using the old software more usable, yes? @jmar777

@jmar777
Copy link

jmar777 commented Feb 23, 2018

@Announcement Yes (depending on your definition of "usable", I suppose). I think I'm just confused regarding your reference to io.js, then. Could you provide a specific example of a security concern?

Perhaps it would help if we clarified that mz is not a reimplementation of node's core API's, but rather operates much closer to, e.g., util.promisify() (i.e., it simply wraps the core API's to make them promise-friendly). In that regard, I'm not sure where you believe the surface area for a security vulnerability exists.

@RyanZim
Copy link
Contributor

RyanZim commented Feb 23, 2018

This module makes Node.js v4, which is still getting security patches till April way easier to use.

@LinusU
Copy link
Contributor

LinusU commented Feb 23, 2018

@Announcement This module's primary purpose is to expose a promisified version of the builtin Node.js API. This is something that isn't present in the latest Node.js version so this is not a shim/polyfill...

Anyhow, I don't see how opening issues titled "pls stop" before even reading thru the code helps anything...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants