Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] nose.tools should use unittest2 if available #25

Open
jpellerin opened this issue Dec 14, 2011 · 2 comments
Open

[patch] nose.tools should use unittest2 if available #25

jpellerin opened this issue Dec 14, 2011 · 2 comments
Assignees

Comments

@jpellerin
Copy link
Member

As the summary says, if unittest2 is available, its assertions should be used.

I have written a patch for this here: http://code.google.com/r/wolever-python-nose-unittest2/source/detail?r=d4d0c62184e710d2fe3712ea8845b1f1fb709e9e

Given that unittest2 claims to be 100% backwards compatible, I don't believe this will create any backwards compatibility problems.

The biggest issue I can see it causing would be if a developer unknowingly uses unittest2 assertions, then another developer without unittest2 runs the tests. They would get an incredibly unhelpful cannot import name assert_in.

I have started to use this patch in my projects, and it seems to work there (although there hasn't been enough time to be sure).

Google Code Info:
Issue #: 392
Author: [email protected]
Created On: 2011-01-16T07:34:31.000Z
Closed On:

@ghost ghost assigned jpellerin Dec 14, 2011
@wolever
Copy link

wolever commented Dec 16, 2011

If I submit a pull request for this, will it be accepted?

@jpellerin
Copy link
Member Author

Seems like a reasonable change to me, thought ideally I'd like to see it tested somehow (maybe a separate tox config?)

Edit: to answer your actual question :) more clearly, a pull request here would get this to the top of the patch queue and would increase the chances of it being accepted soon by a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants