Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command to extract and install client files. #16

Open
nothub opened this issue Apr 15, 2023 · 4 comments
Open

Command to extract and install client files. #16

nothub opened this issue Apr 15, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@nothub
Copy link
Owner

nothub commented Apr 15, 2023

As seen in #15.

@nothub nothub added the enhancement New feature or request label Apr 15, 2023
@limejet
Copy link

limejet commented Aug 17, 2023

It would be neat if this feature could be implemented with Automodpack in mind by extracting both client and server stuff into different directories. That way they can be served to the client and a user would only need a very basic setup to join an Automodpack-enabled server.

@nothub
Copy link
Owner Author

nothub commented Aug 20, 2023

@limejet thanks for your input!

I have never used AutoModpack, are there some specific things I have to care about or is it sufficient or is it sufficient if I expose 2 cli flags to defined the 2 paths?

@limejet
Copy link

limejet commented Aug 20, 2023

By default automodpack just sends files in mods/ and config/ (configurable in automodpack/automodpack-server.json) as well as everything in automodpack/host-modpack. This allows for sending shaderpacks and things of that nature to the client without polluting the server instance with unused files.

A --client flag should be enough to get a working setup, because it could be done in two steps:

  1. mrpack-install <pack-name> /path/to/minecraft/ to set up the instance
  2. something like mrpack-install <pack-name> --client /path/to/minecraft/automodpack/host-modpack

Maybe with the addition of a flag like --data-only (or some better name) that would prevent files not specified in the mrpack (server.jar and such) from being downloaded.


For reference, the way I've set up my server is that players download a "base.mrpack" that just contains quilt, automodpack, and the server address. An first join they get everything else, and this way I only have to update the base pack whenever there's an update to the game, the loader, or automodpack.

@nothub
Copy link
Owner Author

nothub commented Aug 20, 2023

Okay this sounds good, I gonna try to implement this in a clean way that is nice to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants