Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nrt_Event needs unit tests to ensure functionality #548

Open
capnkenny opened this issue Jan 3, 2023 · 3 comments
Open

Nrt_Event needs unit tests to ensure functionality #548

capnkenny opened this issue Jan 3, 2023 · 3 comments
Labels
engine core Tickets pertaining to the engine core codebase.

Comments

@capnkenny
Copy link
Member

capnkenny commented Jan 3, 2023

Describe the issue:

With that said, we'll need unit tests added to ensure that Nrt_Event_* and friends work properly as our original concern was that since it could be of type T, C obviously does not have a very good way of handling this (although your solution looks to do just that).

Originally posted by @capnkenny in #486 (comment)

Please provide the steps to reproduce if possible:
N/A

Expected behaviour:
Unit tests should exist for the Nrt_Event_* functions.

Please tell us about your environment:
N/A

Additional context:
N/A

@capnkenny capnkenny added the engine core Tickets pertaining to the engine core codebase. label Jan 3, 2023
@capnkenny
Copy link
Member Author

Dependent on #486 being merged

@capnkenny capnkenny added the blocked This ticket is blocked for one reason or another. label Jan 3, 2023
@Pheubel
Copy link
Contributor

Pheubel commented Jan 14, 2023

Now that #486 is merged, this can be unblocked, right

@capnkenny capnkenny removed the blocked This ticket is blocked for one reason or another. label Jan 14, 2023
@capnkenny
Copy link
Member Author

Yup, that's correct - thanks for the reminder @Pheubel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engine core Tickets pertaining to the engine core codebase.
Projects
None yet
Development

No branches or pull requests

2 participants