Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GHA] Clang-format does not seem to agree with local clang-format. #586

Open
RubyNova opened this issue Jul 1, 2023 · 0 comments
Open
Labels
bug Something isn't working CI/CD This ticket is related to the CI/CD build pipelines. windows Tickets specifically related to the Windows OS.

Comments

@RubyNova
Copy link
Member

RubyNova commented Jul 1, 2023

Note: for support questions, please use the #engine-user-help channel in our Discord or create a discussion. This repository's issues are reserved for feature requests and bug reports.

Describe the issue:
The clang-format being used by CI seems to output a different result from the clang-format installation I have on Windows 10, meaning I have to apply the CI patch regardless. This indicates to me something is potentially broken on CI.

Please provide the steps to reproduce if possible:

  1. Clone the repo
  2. Install clang-format on Windows 10
  3. run clang-format
  4. push up
  5. open a PR
  6. Observe the issue

Expected behaviour:
Clang-format should do the same modifications regardless of platform.

Please tell us about your environment:

Additional context:
It could be that there's additional flags I need to pass to Clang-Format locally I am unaware of, but just in case, I felt I should log an issue for the CI pipelines.

@RubyNova RubyNova added bug Something isn't working windows Tickets specifically related to the Windows OS. CI/CD This ticket is related to the CI/CD build pipelines. labels Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI/CD This ticket is related to the CI/CD build pipelines. windows Tickets specifically related to the Windows OS.
Projects
None yet
Development

No branches or pull requests

1 participant