You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Changes in the URL hash don't propagate to the config, instead requiring a page reload to become active.
To Reproduce
Steps to reproduce the behavior:
Browse to vnc.html without get variables or hash
Add #path=/other-websockify to URL
Open devtools network inspector
Click "Connect"
See noVNC attempt to connect to /websockify despite the change
Expected behavior
The hash change event was hooked and the config updated, so the application connects to /other-websockify
Client:
OS: Linux (Manjaro)
Browser: Chromium
Browser version: 94.0.4606.81
Server:
noVNC version: 1.20
VNC server: VMware Workstation
WebSocket proxy: websockify 0.10.0
Additional context
In addition to manual updates, this affects updates done by clicking links added to vnc.html, e.g. <a href="#path=/other-ws">...</a>
I worked around this by adding the following line to addSettingsHandlers() in app/ui.js: window.addEventListener("hashchange", UI.initSettings, false);
The text was updated successfully, but these errors were encountered:
This is unfortunately non-trivial as we have to know which parts of the hash that the user actually cares about. We don't want to blindly overwrite settings the user has manually changed in the UI.
I'll leave this open though if someone wants to attempt a fix for this.
Describe the bug
Changes in the URL hash don't propagate to the config, instead requiring a page reload to become active.
To Reproduce
Steps to reproduce the behavior:
vnc.html
without get variables or hash#path=/other-websockify
to URL/websockify
despite the changeExpected behavior
The hash change event was hooked and the config updated, so the application connects to
/other-websockify
Client:
Server:
Additional context
In addition to manual updates, this affects updates done by clicking links added to vnc.html, e.g.
<a href="#path=/other-ws">...</a>
I worked around this by adding the following line to
addSettingsHandlers()
inapp/ui.js
:window.addEventListener("hashchange", UI.initSettings, false);
The text was updated successfully, but these errors were encountered: