Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

view_only=false doesn't work with vnc_lite.html #1662

Open
WebSockit2me opened this issue Jul 11, 2022 · 1 comment
Open

view_only=false doesn't work with vnc_lite.html #1662

WebSockit2me opened this issue Jul 11, 2022 · 1 comment

Comments

@WebSockit2me
Copy link

Describe the bug
vnc_lite.html issue when query parameter is set to view_only=false. Can not move the cursor acting like view_only=true. A work around is to set view_only to nothing eg view_only=

To Reproduce
Go to http://cloudtk.tcl-lang.org/view-only.html to see a live demo of the issue.

Expected behavior
view_only=false query parameter to allow controlling of the cursor.

Client (please complete the following information):

  • OS: Linux64 Ubuntu
  • Browser: Firefox
  • Browser version: 101.0.1 (64-bit)

Server (please complete the following information):

  • noVNC version: 1.3.0
  • VNC server: TigerVNC
  • WebSocket proxy: CloudTk
@CendioOssman
Copy link
Member

It seems we don't check the boolean values, so setting them to anything at all will result in them being turned on. :/

@CendioOssman CendioOssman changed the title vnc_lite.html issue when query parameter is set to view_only=false view_only=false doesn't work with vnc_lite.html Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants