Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NV-2911] 🚀 Feature: option to send email attachments from UI #2313

Closed
2 tasks done
jainpawan21 opened this issue Dec 18, 2022 · 10 comments
Closed
2 tasks done

[NV-2911] 🚀 Feature: option to send email attachments from UI #2313

jainpawan21 opened this issue Dec 18, 2022 · 10 comments
Labels

Comments

@jainpawan21
Copy link
Member

jainpawan21 commented Dec 18, 2022

🔖 Feature description

Novu supports sending email attachments through its sdk
https://docs.novu.co/channels/email/#sending-email-attachments

But this is not working, if we try to send like this from UI
image

🎤 Why is this feature needed ?

To send email attachments from UI

✌️ How do you aim to achieve this?

Maybe implementing a file upload option.

Check the Figma designs here

🔄️ Additional Information

No response

👀 Have you spent some time to check if this feature request has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

Are you willing to submit PR?

None

NV-2911

@github-actions
Copy link

Hi, I'm Jarvis 🤖

I'm a bot built to help you with your contribution to Novu.
I will add instructions and guides on how to run the subset of the Novu platform associated to this issue and make your first contribution.

This issue was tagged as related to @novu/api and the related code is located at the apps/api folder, here is how I can help you:

First time contributing to Novu?

If that's the first time you want to contribute to Novu here are a few simple steps to get you started:

  1. Fork the repository and clone your fork to your local machine.
  2. Install the dependencies using npm run setup:project.
  3. Create a new branch with the number of the issue, for example: 1454-fix-something-cool and start contributing based on the Contributing Guide or the short guide in the section below.
  4. Create a Pull request and follow the template of creation
Run and test `@novu/api` locally

Run API in watch mode

The easiest way to start the API is to run npm run start:api from the root of the repository

Run API integration tests

To validate your changes or simply to run the e2e tests run npm run start:e2e:api. All the e2e tests have the .e2e.ts suffix and usually are located near the controller files of each module.

@mahendraHegde
Copy link
Contributor

@jainpawan21 for file upload do you have any design/flow in mind?
one option is to show file picker as soon as user types attachments:[{}] in the payload section, then we can repopulate name and mime, just to keep the design simple, what do you think?

@jainpawan21
Copy link
Member Author

@mahendraHegde
Currently attachment can be sent using base64 string from UI
let me check if we are planning to add input field in UI for this

@jainpawan21 jainpawan21 changed the title 🚀 Feature: option to send email attachments from UI [NV-2911] 🚀 Feature: option to send email attachments from UI Sep 26, 2023
@jainpawan21 jainpawan21 added Missing Designs Created by Linear-GitHub Sync Design review Created by Linear-GitHub Sync Hacktoberfest Design ready for dev Created by Linear-GitHub Sync and removed Design review Created by Linear-GitHub Sync Missing Designs Created by Linear-GitHub Sync labels Sep 26, 2023
@jainpawan21 jainpawan21 reopened this Sep 29, 2023
@Vishrut19
Copy link

Is anyone working on it?

@chankruze

This comment was marked as abuse.

@Shurtu-gal
Copy link

Hey people is anybody currently working on this?

@nick2432
Copy link
Contributor

nick2432 commented Oct 3, 2023

can i work on this?

@parag477
Copy link

parag477 commented Oct 6, 2023

Hey @jainpawan21 Can you please assign this issue to me. I am willing to work on this issue.

@priyanshagra
Copy link

please assign this to me

@scopsy
Copy link
Contributor

scopsy commented Oct 10, 2023

Need to close this one for now, as the designs are not finalized yet here 🙏

@scopsy scopsy closed this as completed Oct 10, 2023
@jainpawan21 jainpawan21 modified the milestone: Cycle 29 Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

10 participants