Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade @vonage/server-sdk to latest version #4828

Closed
scopsy opened this issue Nov 12, 2023 · 8 comments · Fixed by #4937
Closed

Upgrade @vonage/server-sdk to latest version #4828

scopsy opened this issue Nov 12, 2023 · 8 comments · Fixed by #4937
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed security

Comments

@scopsy
Copy link
Contributor

scopsy commented Nov 12, 2023

Why?

Version 2 of @vonage/server-sdk is using the vulnerable request package.

What?

Updating the @vonage/server-sdk and modifying the code to meet the breaking changes in version 3.

Definition of Done

  • Verifying that all tests pass for the nexmo provider
  • SMS delivery verification with Vonage is working (opening test account)
@scopsy scopsy added good first issue Good for newcomers help wanted Extra attention is needed security labels Nov 12, 2023
@michaldziuba03
Copy link
Contributor

you can assign me

@Mutai-Gilbert
Copy link

Hello, I'll love to contribute to your project.

Kindly let me work on the issue.

@michaldziuba03
Copy link
Contributor

@Mutai-Gilbert it's already assigned

@scopsy
Copy link
Contributor Author

scopsy commented Nov 29, 2023

Hi @michaldziuba03 let me know if you would love to be un-assigned from this 🙏

@michaldziuba03
Copy link
Contributor

@scopsy yeah, you can un-assign me for now

@scopsy
Copy link
Contributor Author

scopsy commented Nov 29, 2023

@Mutai-Gilbert would you still love to pick this up?

@sr-26
Copy link
Contributor

sr-26 commented Dec 1, 2023

Is it still open? If so, can i work on this?

@scopsy scopsy assigned sr-26 and unassigned michaldziuba03 Dec 1, 2023
@scopsy
Copy link
Contributor Author

scopsy commented Dec 1, 2023

@sr-26 thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed security
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants