🐛 Bug Report: @novu/js - Updating the read state of a Notification results in an empty instance

[gtnsimon]

📜 Description

Hello,

With an InApp notification created with the data (https://docs.novu.co/sdks/framework/typescript/steps/inbox) key inside, updating the read state (using notification.read() or notification.unread()) results to an empty Notification instance.

👟 Reproduction steps

Front-end reproduction (with samples Workflows to reproduce the issue): https://stackblitz.com/edit/sb1-gov1vt?file=main.js

// taken from the Stackblitz repro for quick review
import { Novu } from '@novu/js';

const novu = new Novu({
  subscriberId: import.meta.env.VITE_NOVU_SUB_ID,
  applicationIdentifier: import.meta.env.VITE_NOVU_APP_ID,
  backendUrl: 'https://api.novu.co',
  socketUrl: 'https://ws.novu.co',
});

const notifications = await novu.notifications.list();
const [notificationToUpdate] = notifications.data.notifications ?? [];
const updatedNotification = await notificationToUpdate.read();

console.log('updatedNotification', updatedNotification);

👍 Expected behavior

This is a valid Notification instance with data inside:

👎 Actual Behavior with Screenshots

This is bad Notification instance with no data inside:

Novu version

Novu SaaS

npm version

NA

node version

NA

📃 Provide any additional context for the Bug.

The Novu API response when calling https://api.novu.co/v1/inbox/notifications/<NOTIFICATION_ID>/read returns the following payload:

No data key exists and I think this is the root cause. The @novu/client reads the .data key from response.json() to create a Notification which overlaps with Notification.data definition (https://docs.novu.co/sdks/framework/typescript/steps/inbox):

novu/packages/client/src/http-client/http-client.ts

Line 83 in e900c02

return data.data;

👀 Have you spent some time to check if this bug has been raised before?

• I checked and didn't find a similar issue

🏢 Have you read the Contributing Guidelines?

• I have read the Contributing Guidelines

Are you willing to submit PR?

None

[linear]

NV-4353 🐛 Bug Report: @novu/js - Updating the read state of an Notification is resulting in an empty instance

[mohdishaq786]

@gtnsimon i want to work on this issue can you please assign me this issue

[jainpawan21]

@gtnsimon

Thanks for sharing the bug. I can reproduce the issue.

[jainpawan21]

@gtnsimon i want to work on this issue can you please assign me this issue

@mohdishaq786 We appreciate your interest in contribution. As this is a high priority bug, our team will fix this as early as possible.

[jainpawan21]

@gtnsimon

We just fixed this issue. Can you please recheck this? Feel free to update in this thread if you are still seeing the old behavior.