Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing brski http library with one with better logs/error handling #35

Open
aloisklink opened this issue Jun 23, 2023 · 0 comments
Open

Comments

@aloisklink
Copy link
Contributor

aloisklink commented Jun 23, 2023

The brski CLI is extremely difficult to debug if anything goes wrong.

For example, I've encountered errors like:

2023-06-20 01:38:04.961  ERROR httplib_wrapper.cpp:251: httplib::Client fail with "Success"

I've also encountered times where the brski CLI seems to crash, but there are no logs, and brski returns 0 (aka SUCCESS) instead of an error exit code.

It seems like most of these issues are caused by the lack of error handling/logging capabilities in the HTTP library that brski uses: cpp-httplib.

cpp-httplib seems like a simple and easy-to-use library, but it doesn't have good error handling capabilities. In my opinion, we need to replace the http library used by brski to a different library, or even spin up our own HTTP handling.

Potential HTTP library replacements

Server-side

Client-side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant