CAN: MCAN: Implement CAN_MODE_ONE_SHOT [fromlist] #3480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for device runtime power management. Suspending the device will place it into sleep mode, its lowest power state. All config will be lost when suspending the device. Do not allow suspending the device if it is started or has RX filters registered. The application has to reconfigure the CAN device to resume expected operation. Signed-off-by: Ryan Erickson <[email protected]> (cherry picked from commit 631dbd9)
bjarki-andreasen
force-pushed
the
mcan-one-shot
branch
from
2266164 to
1e259e4
Compare
Implement CAN_MODE_ONE_SHOT (DAR mode) for can_mcan. To acheive this, can_mcan has been refactored to use the TX cancel feature to cancel ongoing TX when stopping, as TX can now be cancelled for other reasons than CAN stopping. The CAN_MODE_ONE_SHOT feature depends on CONFIG_CAN_STATS as we need to monitor PEA and PED events, as these are produced if a TX fails. The TCF event only works if a TX is cancelled explicitly using TXBCR due to a bug in the MCAN IP, so it can not be used to detect failed and thus cancelled TX in CAN_MODE_ONE_SHOT. Upstream PR #: 99055 Signed-off-by: Bjarki Arge Andreasen <[email protected]>
bjarki-andreasen
force-pushed
the
mcan-one-shot
branch
from
1e259e4 to
e7b4a13
Compare
Contributor
Author
|
Found potential bug with this approach, working on it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CAN: MCAN: Implement CAN_MODE_ONE_SHOT [fromlist]