Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for eslint.config.mjs ESM flat ESLint config #29493

Closed
1 of 4 tasks
hakimio opened this issue Dec 31, 2024 · 3 comments
Closed
1 of 4 tasks

Add support for eslint.config.mjs ESM flat ESLint config #29493

hakimio opened this issue Dec 31, 2024 · 3 comments
Assignees

Comments

@hakimio
Copy link

hakimio commented Dec 31, 2024

Current Behavior

Currently only CommonJS eslint.config.cjs flat config is supported. The other variants like .mjs, .mts and .cts should be supported too.

angular-eslint already supports both .cjs and .mjs formats: angular-eslint/angular-eslint#2068

Expected Behavior

eslint.config.mjs ESM flat ESLint config should be supported

GitHub Repo

No response

Steps to Reproduce

  1. Try to use eslint.config.mjs config with @nx/eslint:lint executor.

Nx Report

Node           : 20.18.0
OS             : win32-x64
Native Target  : x86_64-windows
bun            : 1.1.41

nx (global)            : 20.3.0
nx                     : 20.3.0
@nx/js                 : 20.3.0
@nx/jest               : 20.3.0
@nx/eslint             : 20.3.0
@nx/workspace          : 20.3.0
@nx/angular            : 20.3.0
@nx/devkit             : 20.3.0
@nx/module-federation  : 20.3.0
@nx/web                : 20.3.0
@nx/webpack            : 20.3.0
typescript             : 5.6.3

Failure Logs

Package Manager Version

No response

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

No response

@jaysoo
Copy link
Member

jaysoo commented Jan 6, 2025

We will be adding this support soon, but will not support .ts, .cts, and .mts files since those are still experimental.

@ndcunningham
Copy link
Contributor

This should be supported now as of #29613

Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants