Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

window-numbering-face doesn't work #9

Open
VladimirAlexiev opened this issue Sep 14, 2015 · 2 comments
Open

window-numbering-face doesn't work #9

VladimirAlexiev opened this issue Sep 14, 2015 · 2 comments

Comments

@VladimirAlexiev
Copy link

https://github.com/nschum/window-numbering.el/blob/master/window-numbering.el#L177:
window-numbering-face should not be quoted.

Also: is it possible to add a tooltip there? Eg "Use Alt-# to select window" .

@nschum
Copy link
Owner

nschum commented Sep 14, 2015

Huh? window-numbering-face isn't a variable. If I didn't quote it, there'd be a "void-variable" error.

@VladimirAlexiev
Copy link
Author

Right! My head was screwed wrongly.
It won't hurt to give an example in the docstring, eg "Set it like this

(defface window-numbering-face '((default :foreground "red" :weight bold))
         "Face for window number in the mode-line.")

BTW the elisp manual sec 37.12.2 Defining Faces says:

  • Macro: defface face spec doc [keyword value]…
    This macro declares FACE as a named face whose default face spec is
    given by SPEC. You should not quote the symbol FACE, and it should
    not end in ‘-face’ (that would be redundant)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants