Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waypoint card component #13

Open
6 tasks
kylebarron opened this issue Nov 22, 2019 · 2 comments
Open
6 tasks

Waypoint card component #13

kylebarron opened this issue Nov 22, 2019 · 2 comments

Comments

@kylebarron
Copy link
Member

Laying out some thoughts about waypoint card component. The cards should be swipeable left and right, but also able to expand vertically for more details.

To do:

  • Get basic example of react-native-snap-carousel working.
  • Figure out vertical expansion.
    • Simplest option: have a "more details" button, that then adds a modal on top, which doesn't change the layout of the card itself.
    • Better UI option: figure out how to expand the card itself vertically on touch or swipe

Details

  • layout={'default'}, is definitely the best choice. This uses FlatList instead of ScrollView, so it will be much more performant.
  • Figure out how to expand the card vertically on touch or swipe. See here for adding onPress.
  • Figure out what the ref prop does. I think this allows access the carousel component by calling this._carousel in the component class?
  • Figure out ordering of waypoints
  • Figure out whether to use ParallaxImage component. Still not 100% what parallax does, other than it makes it prettier. I don't think this is necessary because I'm not going to be showing photos for these cards anyways?

Tips and tricks

  • Reread notes from "Tips and Tricks"
  • "If your data set is huge, consider loading additional chunks of data only when the user has reached the end of the current set. In order to do this, you'll have to play with VirtualizedList's props onEndReached and onEndReachedThreshold"
@kylebarron kylebarron changed the title Waypoint component Waypoint card component Nov 22, 2019
@kylebarron
Copy link
Member Author

Check out "dynamic height".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant