Merge pull request #5 from nathanjdunn/analysis-zdr5DJ

nthndnn · web-flow · commit 4da31719a8b3 · 2018-01-06T22:47:47.000Z
Apply fixes from StyleCI
diff --git a/src/Api/PaymentSources/Exceptions/PaymentGatewayCurrencyIncompatibleException.php b/src/Api/PaymentSources/Exceptions/PaymentGatewayCurrencyIncompatibleException.php
@@ -6,5 +6,4 @@
 
 class PaymentGatewayCurrencyIncompatibleException extends HttpException
 {
-
 }
diff --git a/src/Api/PaymentSources/Exceptions/PaymentMethodNotPresentException.php b/src/Api/PaymentSources/Exceptions/PaymentMethodNotPresentException.php
@@ -6,5 +6,4 @@
 
 class PaymentMethodNotPresentException extends HttpException
 {
-
 }
diff --git a/src/Api/PaymentSources/Exceptions/PaymentMethodVerificationFailedException.php b/src/Api/PaymentSources/Exceptions/PaymentMethodVerificationFailedException.php
@@ -6,5 +6,4 @@
 
 class PaymentMethodVerificationFailedException extends HttpException
 {
-
 }
diff --git a/src/Api/PaymentSources/Exceptions/PaymentProcessingFailedException.php b/src/Api/PaymentSources/Exceptions/PaymentProcessingFailedException.php
@@ -6,5 +6,4 @@
 
 class PaymentProcessingFailedException extends HttpException
 {
-
 }
diff --git a/src/Exceptions/ApiAuthenticationFailedException.php b/src/Exceptions/ApiAuthenticationFailedException.php
@@ -6,5 +6,4 @@
 
 class ApiAuthenticationFailedException extends HttpException
 {
-
-}
+}
diff --git a/src/Exceptions/ApiAuthorizationFailedException.php b/src/Exceptions/ApiAuthorizationFailedException.php
@@ -6,5 +6,4 @@
 
 class ApiAuthorizationFailedException extends HttpException
 {
-
-}
+}
diff --git a/src/Exceptions/ApiRequestLimitExceededException.php b/src/Exceptions/ApiRequestLimitExceededException.php
@@ -6,5 +6,4 @@
 
 class ApiRequestLimitExceededException extends HttpException
 {
-
-}
+}
diff --git a/src/Exceptions/ConfigurationIncompatibleException.php b/src/Exceptions/ConfigurationIncompatibleException.php
@@ -6,5 +6,4 @@
 
 class ConfigurationIncompatibleException extends HttpException
 {
-
-}
+}
diff --git a/src/Exceptions/DbConnectionFailureException.php b/src/Exceptions/DbConnectionFailureException.php
@@ -6,5 +6,4 @@
 
 class DbConnectionFailureException extends HttpException
 {
-
-}
+}
diff --git a/src/Exceptions/DuplicateEntryExceptions.php b/src/Exceptions/DuplicateEntryExceptions.php
@@ -6,5 +6,4 @@
 
 class DuplicateEntryExceptions extends HttpException
 {
-
-}
+}
diff --git a/src/Exceptions/HttpMethodNotSupportedException.php b/src/Exceptions/HttpMethodNotSupportedException.php
@@ -6,5 +6,4 @@
 
 class HttpMethodNotSupportedException extends HttpException
 {
-
-}
+}
diff --git a/src/Exceptions/InternalErrorException.php b/src/Exceptions/InternalErrorException.php
@@ -6,5 +6,4 @@
 
 class InternalErrorException extends HttpException
 {
-
-}
+}
diff --git a/src/Exceptions/InternalTemporaryErrorException.php b/src/Exceptions/InternalTemporaryErrorException.php
@@ -6,5 +6,4 @@
 
 class InternalTemporaryErrorException extends HttpException
 {
-
-}
+}
diff --git a/src/Exceptions/InvalidRequestException.php b/src/Exceptions/InvalidRequestException.php
@@ -6,5 +6,4 @@
 
 class InvalidRequestException extends HttpException
 {
-
-}
+}
diff --git a/src/Exceptions/InvalidStateForRequestException.php b/src/Exceptions/InvalidStateForRequestException.php
@@ -6,5 +6,4 @@
 
 class InvalidStateForRequestException extends HttpException
 {
-
-}
+}
diff --git a/src/Exceptions/ParamWrongValueException.php b/src/Exceptions/ParamWrongValueException.php
@@ -6,5 +6,4 @@
 
 class ParamWrongValueException extends HttpException
 {
-
-}
+}
diff --git a/src/Exceptions/RequestBlockedException.php b/src/Exceptions/RequestBlockedException.php
@@ -6,5 +6,4 @@
 
 class RequestBlockedException extends HttpException
 {
-
-}
+}
diff --git a/src/Exceptions/ResourceLimitExceededException.php b/src/Exceptions/ResourceLimitExceededException.php
@@ -6,5 +6,4 @@
 
 class ResourceLimitExceededException extends HttpException
 {
-
-}
+}
diff --git a/src/Exceptions/ResourceLimitExhaustedException.php b/src/Exceptions/ResourceLimitExhaustedException.php
@@ -6,5 +6,4 @@
 
 class ResourceLimitExhaustedException extends HttpException
 {
-
 }
diff --git a/src/Exceptions/ResourceNotFoundException.php b/src/Exceptions/ResourceNotFoundException.php
@@ -6,5 +6,4 @@
 
 class ResourceNotFoundException extends HttpException
 {
-
 }
diff --git a/src/Exceptions/SiteNotFoundException.php b/src/Exceptions/SiteNotFoundException.php
@@ -6,5 +6,4 @@
 
 class SiteNotFoundException extends HttpException
 {
-
 }
diff --git a/src/HttpClient/Builder.php b/src/HttpClient/Builder.php
@@ -68,7 +68,7 @@ public function getHttpClient(): HttpMethodsClient
         $authenticator = $this->getAuthenticationPlugin();
 
         $this->httpMethodsClient = new HttpMethodsClient(
-            new PluginClient($this->httpClient, [$authenticator, new ErrorPlugin]),
+            new PluginClient($this->httpClient, [$authenticator, new ErrorPlugin()]),
             $this->requestFactory
         );
 
diff --git a/src/HttpClient/Exception/ApiExceptionHandler.php b/src/HttpClient/Exception/ApiExceptionHandler.php
@@ -43,14 +43,13 @@ public function handle()
 
     /**
      * @param array $content
+     *
      * @return string|null
      */
     private function formatException(array $content)
     {
         if (isset($content['api_error_code'])) {
             return sprintf('NathanDunn\Chargebee\Exceptions\%sException', Str::studly($content['api_error_code']));
         }
-
-        return null;
     }
 }
diff --git a/src/Util/Str.php b/src/Util/Str.php
@@ -6,6 +6,7 @@ class Str
 {
     /**
      * @param $value
+     *
      * @return string
      */
     public static function studly($value): string
@@ -14,4 +15,4 @@ public static function studly($value): string
             ucwords(str_replace(['-', '_'], ' ', $value))
         );
     }
-}
+}
diff --git a/tests/Unit/HttpClient/Exception/ApiExceptionHandlerTest.php b/tests/Unit/HttpClient/Exception/ApiExceptionHandlerTest.php
@@ -36,6 +36,7 @@ public function should_throw_client_error_exception_for_request()
 
     /**
      * @param string $path
+     *
      * @return Response
      */
     private function getResponse(string $path)
@@ -44,28 +45,28 @@ private function getResponse(string $path)
 
         $headers = [
             'Cache-Control' => [
-                "no-store, no-cache, must-revalidate"
+                'no-store, no-cache, must-revalidate',
             ],
             'Content-Type' => [
-                "application/json;charset=UTF-8"
+                'application/json;charset=UTF-8',
             ],
             'Date' => [
-                "Sat, 06 Jan 2018 20:23:27 GMT"
+                'Sat, 06 Jan 2018 20:23:27 GMT',
             ],
             'Pragma' => [
-                "no-cache"
+                'no-cache',
             ],
             'Server' => [
-                "ChargeBee"
+                'ChargeBee',
             ],
             'Vary' => [
-                "Accept-Encoding"
+                'Accept-Encoding',
             ],
             'Content-Length' => [
-                "212"
+                '212',
             ],
             'Connection' => [
-                "keep-alive"
+                'keep-alive',
             ],
         ];
 
@@ -79,16 +80,16 @@ private function getRequest()
     {
         $headers = [
             'Host' => [
-                "test.chargebee.com",
+                'test.chargebee.com',
             ],
             'Content-Type' => [
-                "application/x-www-form-urlencoded"
+                'application/x-www-form-urlencoded',
             ],
             'Authorization' => [
-                "Basic xxx"
+                'Basic xxx',
             ],
         ];
 
         return new Request('POST', 'https://test.chargebee.com/api/v2/customers', $headers, 'email=github%40nathandunn.');
     }
-}
+}

Original file line number	Diff line number	Diff line change
`@@ -6,5 +6,4 @@`
`6`	`6`
`7`	`7`	`class PaymentGatewayCurrencyIncompatibleException extends HttpException`
`8`	`8`	`{`
`9`		`-`
`10`	`9`	`}`
Original file line number	Diff line number	Diff line change
`@@ -6,5 +6,4 @@`
`6`	`6`
`7`	`7`	`class PaymentMethodNotPresentException extends HttpException`
`8`	`8`	`{`
`9`		`-`
`10`	`9`	`}`
Original file line number	Diff line number	Diff line change
`@@ -6,5 +6,4 @@`
`6`	`6`
`7`	`7`	`class PaymentMethodVerificationFailedException extends HttpException`
`8`	`8`	`{`
`9`		`-`
`10`	`9`	`}`
Original file line number	Diff line number	Diff line change
`@@ -6,5 +6,4 @@`
`6`	`6`
`7`	`7`	`class PaymentProcessingFailedException extends HttpException`
`8`	`8`	`{`
`9`		`-`
`10`	`9`	`}`
Original file line number	Diff line number	Diff line change
`@@ -6,5 +6,4 @@`
`6`	`6`
`7`	`7`	`class ApiAuthenticationFailedException extends HttpException`
`8`	`8`	`{`
`9`		`-`
`10`		`-}`
	`9`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -6,5 +6,4 @@`
`6`	`6`
`7`	`7`	`class ApiAuthorizationFailedException extends HttpException`
`8`	`8`	`{`
`9`		`-`
`10`		`-}`
	`9`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -6,5 +6,4 @@`
`6`	`6`
`7`	`7`	`class ApiRequestLimitExceededException extends HttpException`
`8`	`8`	`{`
`9`		`-`
`10`		`-}`
	`9`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -6,5 +6,4 @@`
`6`	`6`
`7`	`7`	`class ConfigurationIncompatibleException extends HttpException`
`8`	`8`	`{`
`9`		`-`
`10`		`-}`
	`9`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -6,5 +6,4 @@`
`6`	`6`
`7`	`7`	`class DbConnectionFailureException extends HttpException`
`8`	`8`	`{`
`9`		`-`
`10`		`-}`
	`9`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -6,5 +6,4 @@`
`6`	`6`
`7`	`7`	`class DuplicateEntryExceptions extends HttpException`
`8`	`8`	`{`
`9`		`-`
`10`		`-}`
	`9`	`+}`