Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEOS-1455] Table search doesn't work on transformer columns when value is updated in place but not saved #2685

Open
nickzelei opened this issue Sep 12, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@nickzelei
Copy link
Member

nickzelei commented Sep 12, 2024

I update a transformer in the form but havent hit save yet. If i search for that updated transformer, it does not come up in the search until I click update on the form itself. I think this is related to the tanstack but that is currently documented in the code

Looks like we already have code for this, but there is this edge case.

        // row.getValue doesn't work here due to a tanstack bug where the transformer value is out of sync with getValue
        // row.original works here. There must be a caching bug with the transformer prop being an object.
        // This may be related: https://github.com/TanStack/table/issues/5363
        const rowVal = row.original.transformer;
        const tsource = transformerHandler.getSystemTransformerBySource(
          rowVal.source
        );
        const sourceName = tsource?.name.toLowerCase() ?? 'select transformer';
        return sourceName.includes((value as string)?.toLowerCase());

We should revisit this once this tanstack issue is resolved.

`getValue` cache not invalidating when `accessorFn` is updated · Issue #5363 · TanStack/table

From SyncLinear.com | NEOS-1455

@nickzelei nickzelei added the bug Something isn't working label Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant