Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEOS-1581] Update tests to use slogt #2872

Open
nickzelei opened this issue Oct 28, 2024 · 1 comment
Open

[NEOS-1581] Update tests to use slogt #2872

nickzelei opened this issue Oct 28, 2024 · 1 comment
Labels
good first issue Good for newcomers Tech Debt Created by Linear-GitHub Sync

Comments

@nickzelei
Copy link
Member

found this package that bridges the *testing.T logger with slog.Logger

Would be great to use this in our tests and replace our current use of discardLogger

https://github.com/neilotoole/slogt

That package is pretty small, it may make sense to just move this into internal/slogt instead of adding as an external dependency.

From SyncLinear.com | NEOS-1581

@nickzelei nickzelei added good first issue Good for newcomers Hacktober Created by Linear-GitHub Sync Tech Debt Created by Linear-GitHub Sync labels Oct 28, 2024
@nickzelei nickzelei removed the Hacktober Created by Linear-GitHub Sync label Nov 5, 2024
@nickzelei
Copy link
Member Author

@alisha.kawaguchi has done some work here to get this setup, now we just need to apply it everywhere: https://github.com/nucleuscloud/neosync/blob/main/internal/testutil/utils.go#L22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers Tech Debt Created by Linear-GitHub Sync
Projects
None yet
Development

No branches or pull requests

1 participant