From 4d04600a48dd403a475221740004711c5ed4277e Mon Sep 17 00:00:00 2001
From: Piotr Roslaniec <p.roslaniec@gmail.com>
Date: Thu, 22 Feb 2024 15:55:14 +0100
Subject: [PATCH] refactor: hide g_inv from internat apis

---
 ferveo/src/api.rs     | 3 ---
 ferveo/src/lib.rs     | 1 -
 ferveo/src/pvss.rs    | 2 --
 ferveo/src/refresh.rs | 4 ++--
 4 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/ferveo/src/api.rs b/ferveo/src/api.rs
index 389acb4a..923de60a 100644
--- a/ferveo/src/api.rs
+++ b/ferveo/src/api.rs
@@ -323,7 +323,6 @@ impl AggregatedTranscript {
             validator_keypair,
             dkg.0.me.share_index,
             &dkg.0.domain_points(),
-            &dkg.0.pvss_params.g_inv(),
         )
     }
 
@@ -547,14 +546,12 @@ impl PrivateKeyShare {
         share_index: u32,
         domain_points: &[DomainPoint<E>],
     ) -> Result<DecryptionSharePrecomputed> {
-        let g_inv = PubliclyVerifiableParams::<E>::default().g_inv();
         let share = self.0.create_decryption_share_simple_precomputed(
             &ciphertext_header.0,
             aad,
             validator_keypair,
             share_index,
             domain_points,
-            &g_inv,
         )?;
         Ok(share)
     }
diff --git a/ferveo/src/lib.rs b/ferveo/src/lib.rs
index 5d52a4db..9a43b1f2 100644
--- a/ferveo/src/lib.rs
+++ b/ferveo/src/lib.rs
@@ -308,7 +308,6 @@ mod test_dkg_full {
                             validator_keypair,
                             validator.share_index,
                             &domain_points,
-                            &dkg.pvss_params.g_inv(),
                         )
                         .unwrap()
                 })
diff --git a/ferveo/src/pvss.rs b/ferveo/src/pvss.rs
index 086cea50..dc07d5b7 100644
--- a/ferveo/src/pvss.rs
+++ b/ferveo/src/pvss.rs
@@ -359,7 +359,6 @@ impl<E: Pairing, T: Aggregate> PubliclyVerifiableSS<E, T> {
         validator_keypair: &Keypair<E>,
         share_index: u32,
         domain_points: &[DomainPoint<E>],
-        g_inv: &E::G1Prepared,
     ) -> Result<DecryptionSharePrecomputed<E>> {
         self.decrypt_private_key_share(validator_keypair, share_index)?
             .create_decryption_share_simple_precomputed(
@@ -368,7 +367,6 @@ impl<E: Pairing, T: Aggregate> PubliclyVerifiableSS<E, T> {
                 validator_keypair,
                 share_index,
                 domain_points,
-                g_inv,
             )
     }
 
diff --git a/ferveo/src/refresh.rs b/ferveo/src/refresh.rs
index f6adef82..bf633fa2 100644
--- a/ferveo/src/refresh.rs
+++ b/ferveo/src/refresh.rs
@@ -89,8 +89,8 @@ impl<E: Pairing> PrivateKeyShare<E> {
         validator_keypair: &Keypair<E>,
         share_index: u32,
         domain_points: &[DomainPoint<E>],
-        g_inv: &E::G1Prepared,
     ) -> Result<DecryptionSharePrecomputed<E>> {
+        let g_inv = PubliclyVerifiableParams::<E>::default().g_inv();
         // In precomputed variant, we offload some of the decryption related computation to the server-side:
         // We use the `prepare_combine_simple` function to precompute the lagrange coefficients
         let lagrange_coeffs = prepare_combine_simple::<E>(domain_points);
@@ -104,7 +104,7 @@ impl<E: Pairing> PrivateKeyShare<E> {
             ciphertext_header,
             aad,
             lagrange_coeff,
-            g_inv,
+            &g_inv,
         )
         .map_err(|e| e.into())
     }