-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wayland support #1464
Comments
Nuclear uses electron version 12 of electron. So this change is impossible to make right now. The electron dependency needs to be updated first. I wonder if there are arguments against bumping electron to something more recent. |
One major problem with newer versions is that they change the way IPC works, and since Nuclear uses IPC heavily, it would be a lot of effort to migrate that. Those parts are also very weakly tested, so it's hard to make the migration with confidence. |
No matter how tedious it might be, I wanna get it done. I think it's worth the effort also because it's almost been 3 years that there are no more updates. Hopefully I can also figure out a way to write tests for those IPC. |
A couple of the issues Ive met so far trying to bump electron to the latest major version(33), for visibility:
At last, I noticed the |
electron-timber is old, limited, and umaintained. Last time I tried updating Electron I had to reimplement this myself from scratch (my bad for relying on anything made by that sindresorhus guy). He takes a hardline stance on ES modules, trying to force packages that import his modules to use them. You can tell because he deliberately breaks CJS compatibility even if there's no reason too. The only way he even updated that package was to break compatibility on purpose after several years of not maintaining it. He didn't change anything else. My tip is to never use anything released by or contributed to by that guy. |
This looks like a simple, better maintained alternative to the logging problem https://github.com/megahertz/electron-log. Have you seen/considered it before? |
This is fine, though it solves only a small part of the problem. I haven't tried it. Implementing something like that directly in Nuclear is also possible. |
I moved the logging discussion to a new issue #1734. The topic was drifting from original post. |
To use electron-based applications natively under Wayland, the following flags need to be added to your application exec command line (for Electron 20): --ozone-platform-hint=auto.
With the flatpak version I doesn't works
The text was updated successfully, but these errors were encountered: