Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual bug in local library progress bar #1644

Open
rkben opened this issue Jul 15, 2024 · 2 comments
Open

Visual bug in local library progress bar #1644

rkben opened this issue Jul 15, 2024 · 2 comments
Labels
bug This issue identifies a bug in Nuclear.

Comments

@rkben
Copy link

rkben commented Jul 15, 2024

Platform:
macOS Sonoma 14.5, arm64

Nuclear version:
git master: 022ba2b

Description of the issue:
Visual bug in local library progress bar. I suspect this is due to the width of the characters in the total number 34857. The currently scanned count is not viewable at all until its width is 4 characters wide.

image

@rkben rkben added the bug This issue identifies a bug in Nuclear. label Jul 15, 2024
@nukeop
Copy link
Owner

nukeop commented Jul 15, 2024

You're right, we're using this library: https://react.semantic-ui.com/modules/progress/

I guess this can be handled by CSS. By the way, did you notice any improvement in the scanning time? Did it handle your library well?

@rkben
Copy link
Author

rkben commented Jul 15, 2024

Bit of padding looks like it fixed it without looking too strange.
Demo:
https://codesandbox.io/s/semantic-ui-example-forked-9rvtl5?file=/example.js

.progress {
    .bar {
        padding-left: 100px;
    }
}

RE: library scan
I'd say its on par with other media players such as Foobar2000 and Cog. Around 1 hour to import (give or take 20 minutes).
The UI interaction being locked for an extended period of time is a bit annoying, but that's typical behavior with large libraries in other audio players.

It does seem to crash eventually once it tries to display the entries, but that was with devtools open and running in development mode. Another scan is in progress using the release build.

Edit: Off-topic scanner performance continued in #help thread via Discord.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue identifies a bug in Nuclear.
Projects
None yet
Development

No branches or pull requests

2 participants