Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add localization to 'Buy now' button as prop #19

Open
mangione77 opened this issue Jun 10, 2019 · 3 comments
Open

Add localization to 'Buy now' button as prop #19

mangione77 opened this issue Jun 10, 2019 · 3 comments

Comments

@mangione77
Copy link

Hello,

Thanks for your great work, it's been really useful.

Would it be a possibility to extend the functionality of the ProductCard, so it accepts the text to display in the 'Buy now' button as prop? Right now I'm editing the source code in the bundle and it's not that easy as passing a prop.

Thanks again for the awesome work!

@nukeop
Copy link
Owner

nukeop commented Jun 10, 2019

Thank you for your kind words. Would you like to submit a PR, or would you rather have me do it instead? I can do it tomorrow and update the package then.

@mangione77
Copy link
Author

Thank you for the quick response. I think it would be quicker/easier if you add the prop. I can submit a PR if you wish, but it would take a couple of days.

Thanks!

@nukeop
Copy link
Owner

nukeop commented Jun 12, 2019

Ok, I added a new buttonText prop for that card and published the new version on npm. Update to 1.5.2 and let me know if that fixes your problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants