Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Are system-suspend-(hibernate) supposed to be app icons? #3681

Open
palob opened this issue Apr 19, 2017 · 4 comments · May be fixed by #4585
Open

Are system-suspend-(hibernate) supposed to be app icons? #3681

palob opened this issue Apr 19, 2017 · 4 comments · May be fixed by #4585
Assignees
@Foggalong
Labels
question

Comments

@palob
Copy link
Member

palob commented Apr 19, 2017 •
edited
Loading

We've got

  • system-suspend-hibernate

and

  • system-suspend

in Circle/Square. Are they really app icons? Where are those shown?
@palob palob added the question label Apr 19, 2017
@bilelmoussaoui
Copy link
Contributor

Those icons were added here 79649f4 in order to fix #16

@Foggalong
Copy link
Contributor

Foggalong commented Apr 19, 2017 •
edited
Loading

system-suspend-hibernate.svg was originally added by the Faenza Commit so can probably be removed. The system-suspend.svg was added to fix #16, reading which it sounds like these icon should be handled exclusively by the base theme.

@palob
Copy link
Member Author

palob commented Apr 19, 2017 •
edited
Loading

Looking at the screenshot in #16 those icons shouldn't be app icons at all indeed.

system-hibernate and system-restart might be out of place as well.

@ghost ghost mentioned this issue Apr 24, 2017
Closed
@bilelmoussaoui bilelmoussaoui mentioned this issue Apr 24, 2017
Closed
@Foggalong Foggalong self-assigned this Sep 5, 2018
@Foggalong
Copy link
Contributor

@palob Just come across this issue again and yeah they shouldn't be app icons. They're showing up in the wrong place on my new system. Will get a new fix for that before next release.

@Foggalong Foggalong added this to the 18.09.12 milestone Sep 5, 2018
@Foggalong Foggalong linked a pull request Sep 19, 2018 that will close this issue
Open
@Foggalong Foggalong modified the milestones: 18.09.19, 18.10.03 Sep 19, 2018
@Foggalong Foggalong removed this from the 18.10.03 milestone Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Foggalong Foggalong

Labels
question
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed problematic system-* icons numixproject/numix-core
3 participants
@Foggalong @palob @bilelmoussaoui