Add more tests for -0.0

Author: juntyr

quaddtype/tests/test_quaddtype.py

@@ -35,22 +35,28 @@ def test_basic_equality():
 
 
 @pytest.mark.parametrize("op", ["add", "sub", "mul", "truediv", "pow", "copysign"])
-@pytest.mark.parametrize("other", ["3.0", "12.5", "100.0", "0.0", "-0.0", "inf", "-inf", "nan", "-nan"])
-def test_binary_ops(op, other):
-    if op == "truediv" and float(other) == 0:
+@pytest.mark.parametrize("a", ["3.0", "12.5", "100.0", "0.0", "-0.0", "inf", "-inf", "nan", "-nan"])
+@pytest.mark.parametrize("b", ["3.0", "12.5", "100.0", "0.0", "-0.0", "inf", "-inf", "nan", "-nan"])
+def test_binary_ops(op, a, b):
+    if op == "truediv" and float(b) == 0:
         pytest.xfail("float division by zero")
 
     op_func = getattr(operator, op, None) or getattr(np, op)
-    quad_a = QuadPrecision("12.5")
-    quad_b = QuadPrecision(other)
-    float_a = 12.5
-    float_b = float(other)
+    quad_a = QuadPrecision(a)
+    quad_b = QuadPrecision(b)
+    float_a = float(a)
+    float_b = float(b)
 
     quad_result = op_func(quad_a, quad_b)
     float_result = op_func(float_a, float_b)
 
     np.testing.assert_allclose(np.float64(quad_result), float_result, atol=1e-10, rtol=0, equal_nan=True)
 
+    # Check sign for zero results
+    if float_result == 0.0:
+        assert np.signbit(float_result) == np.signbit(
+            quad_result), f"Zero sign mismatch for {op}({a}, {b})"
+
 
 @pytest.mark.parametrize("op", ["eq", "ne", "le", "lt", "ge", "gt"])
 @pytest.mark.parametrize("a", ["3.0", "12.5", "100.0", "0.0", "-0.0", "inf", "-inf", "nan", "-nan"])
@@ -93,6 +99,11 @@ def test_array_minmax(op, a, b):
 
     np.testing.assert_array_equal(quad_res.astype(float), float_res)
 
+    # Check sign for zero results
+    if float_result == 0.0:
+        assert np.signbit(float_result) == np.signbit(
+            quad_result), f"Zero sign mismatch for {op}({a}, {b})"
+
 
 @pytest.mark.parametrize("op", ["amin", "amax", "nanmin", "nanmax"])
 @pytest.mark.parametrize("a", ["3.0", "12.5", "100.0", "0.0", "-0.0", "inf", "-inf", "nan", "-nan"])
@@ -107,6 +118,11 @@ def test_array_aminmax(op, a, b):
 
     np.testing.assert_array_equal(np.array(quad_res).astype(float), float_res)
 
+    # Check sign for zero results
+    if float_result == 0.0:
+        assert np.signbit(float_result) == np.signbit(
+            quad_result), f"Zero sign mismatch for {op}({a}, {b})"
+
 
 @pytest.mark.parametrize("op", ["negative", "positive", "absolute", "sign", "signbit", "isfinite", "isinf", "isnan", "sqrt", "square", "reciprocal"])
 @pytest.mark.parametrize("val", ["3.0", "-3.0", "12.5", "100.0", "1e100", "0.0", "-0.0", "inf", "-inf", "nan", "-nan"])
@@ -126,7 +142,7 @@ def test_unary_ops(op, val):
 
         np.testing.assert_array_equal(np.array(quad_result).astype(float), float_result)
 
-        if op in ["negative", "positive", "absolute", "sign"]:
+        if (float_result == 0.0) and (op not in ["signbit", "isfinite", "isinf", "isnan"]):
             assert np.signbit(float_result) == np.signbit(quad_result)
 
 
@@ -290,6 +306,11 @@ def test_logarithmic_functions(op, val):
     np.testing.assert_allclose(float(quad_result), float_result, rtol=rtol, atol=atol,
                                err_msg=f"Value mismatch for {op}({val})")
 
+    # Check sign for zero results
+    if float_result == 0.0:
+        assert np.signbit(float_result) == np.signbit(
+            quad_result), f"Zero sign mismatch for {op}({a}, {b})"
+
 
 @pytest.mark.parametrize("val", [
     # Basic cases around -1 (critical point for log1p)
@@ -304,6 +325,8 @@ def test_logarithmic_functions(op, val):
     "-1.1", "-2.0", "-10.0",
     # Large positive values
     "1e10", "1e15", "1e100",
+    # Edge cases
+    "0.0", "-0.0",
     # Special values
     "inf", "-inf", "nan", "-nan"
 ])
@@ -341,9 +364,16 @@ def test_log1p(val):
     np.testing.assert_allclose(float(quad_result), float_result, rtol=rtol, atol=atol,
                                err_msg=f"Value mismatch for log1p({val})")
 
+    # Check sign for zero results
+    if float_result == 0.0:
+        assert np.signbit(float_result) == np.signbit(
+            quad_result), f"Zero sign mismatch for {op}({val})"
+
 def test_inf():
     assert QuadPrecision("inf") > QuadPrecision("1e1000")
+    assert np.signbit(QuadPrecision("inf")) == 0
     assert QuadPrecision("-inf") < QuadPrecision("-1e1000")
+    assert np.signbit(QuadPrecision("-inf")) == 1
 
 
 def test_dtype_creation():