Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to use NUSMods api and inernet connection issues. #115

Open
gy716 opened this issue Oct 31, 2020 · 2 comments
Open

Request to use NUSMods api and inernet connection issues. #115

gy716 opened this issue Oct 31, 2020 · 2 comments

Comments

@gy716
Copy link

gy716 commented Oct 31, 2020

Library

NUSMods API

Purpose

We want to use NUSMods API to check the existence of the module entererd by user and get more information on each module.

License

MIT license
https://github.com/nusmodifications/nusmods

URL issues

Is it okay that the app only work if there is internet connection? Because we need to send requests to the API and fetch data from it. We have tried to download the json file in advance and put it into the resource folder. But there are many problems when packaging the jar. So we want to make the app fetch data from api once it is started, where internet connection is necessary.

@okkhoy
Copy link

okkhoy commented Oct 31, 2020

Use of API approved 👍

Is it okay that the app only work if there is internet connection?

See: https://nus-cs2113-ay2021s1.github.io/website/admin/tp-constraints.html#recommendation-testability and decide for yourself. The teaching team will not make this decision for you.

@gy716
Copy link
Author

gy716 commented Oct 31, 2020

OK, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants