Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Custom Modules to Timetable #3373

Open
wants to merge 91 commits into
base: master
Choose a base branch
from

Conversation

seanlowjk
Copy link
Contributor

@seanlowjk seanlowjk commented Dec 15, 2021

Context

Resolves #2040

The idea is to implement custom modules for students who wish
to add modules that are not part of the NUS curriculum (DYOMs)
or TA classes. (Especially for SoC TAs)

Implementation

Timetable.-.NUSMods.-.Google.Chrome.2021-12-15.17-38-22.mp4

With guidance from @chrisgzf , we have developed a solution which allows
users to add their custom modules.

This is done via CustomLessons which are not readonly. As a result, we can
incorporate these custom lessons into the TimetablesState to be stored for future use.

Other Information

  1. Once this is integrated, will we need to integrate this feature as well with
    regards to the export feature?
  2. My engineering decisions have been briefly mentioned above. Do let me know
    if there is room for improvement.

TODOs

  • Add Component and Logic Tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add 'Custom Modules' to timetable
4 participants